NotificationsYou must be signed in to change notification settings
Fork15
Star22

[ISSUE-10] Implemented propagation of pg sphere version.#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vitcpp merged 1 commit intopostgrespro:masterfromvitcpp:10-pgsphere-version

Jun 28, 2023

Merged

[ISSUE-10] Implemented propagation of pg sphere version.#23

vitcpp merged 1 commit intopostgrespro:masterfromvitcpp:10-pgsphere-version

Jun 28, 2023

Conversation

Copy link

Contributor

vitcpp commentedJun 27, 2023

Implemented propagation of pg sphere version from Makefile into the code. Fixed pg_sphere_version function.

vitcpp mentioned this pull request

Jun 27, 2023

pg_sphere_version() reports version that is different from extension version.#10

Closed

Copy link

ContributorAuthor

vitcpp commentedJun 27, 2023•
edited
Loading

It seems there are build problems on 11+ versions. The error is occured when compiling with clang. It seems PG_CFLAGS is not used with clang. Not sure, how clang compilation is performed. I see no clang rules. It is interesting that there is no clang compilation with 10 version. Investigating it.

[ISSUE-10] Implemented propagation of pg sphere version.

894f9bb

vitcpp force-pushed the10-pgsphere-version branch fromf38b142 to894f9bbCompare

June 27, 2023 11:57

Copy link

ContributorAuthor

vitcpp commentedJun 27, 2023

The problem with clang was because of JIT compilation (--with-llwm option). Variables PG_CXXFLAGS, PG_CFLAGS are not propagated into clang compilation. Using PG_CPPFLAGS fixes the problem.