Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Alter spoint op family to add missed operator 17 (<->)#121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

vitcpp
Copy link
Contributor

The upgrade script misses the altering of spoint operator family to add operator 17. It is required for k-NN search.

@df7cb
Copy link
Contributor

Fwiw I think you shouldn't touch --1.5.0.sql given that has been released, even when it was just a pre-release. (I would suggest labeling pre-releases as beta or RC, then the question might not be as relevant.)

@vitcpp
Copy link
ContributorAuthor

@df7cb That was my unspoken question - whether to move the tag or create 1.5.1. Looking at our README I think to create 1.5.1. I will update the patch. It seems, the next release will be 1.5.1. Zeroes are unhappy :) Thank you.

@esabol
Copy link
Contributor

Pre-releases are not releases. I'm ok with this being part of 1.5.0, personally.

@df7cb
Copy link
Contributor

But git tags are tags and should not be moved if people might already have seen them. I have not yet built Debian packages from that tag yet, but if I had and you moved it around afterwards, I would be quite upset.

Also, if the pre-release is supposed to serve any purpose, it is for people to actually build and test it. Please don't confuse people by making another release with the same name.

@vitcpp
Copy link
ContributorAuthor

@esabol It seems, it is not easy to move the tag, the branch is protected. Furthermore,@df7cb has reasonable arguments against it. I will create 1.5.1 this time. Later, I will assign pre-releases more carefully.

df7cb reacted with thumbs up emoji

@esabol
Copy link
Contributor

Well, Ok, but then there's no point in having pre-releases at all, and I suggest we not have them in the future.

@df7cb
Copy link
Contributor

Just name them 1.6rc1 or the like and everything is fine.

vitcpp reacted with thumbs up emoji

The upgrade script misses the altering of spoint operator familyto add operator 17. It is required for k-NN search.Change the version to 1.5.1.
@vitcppvitcppforce-pushed thespoint-opfamily-add-op-17 branch from382a3c5 toaaf42a8CompareApril 17, 2024 16:19
@vitcpp
Copy link
ContributorAuthor

@esabol Are you ok with these changes?

esabol reacted with thumbs up emoji

Copy link
Contributor

@esabolesabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I approved the PR 3 days ago, but I just saw you made another commit. Yes, it still looks good to me.

@vitcppvitcpp merged commitdaa9478 intopostgrespro:masterApr 22, 2024
14 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@esabolesabolesabol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vitcpp@df7cb@esabol

[8]ページ先頭

©2009-2025 Movatter.jp