- Notifications
You must be signed in to change notification settings - Fork15
fix Makefile dist target#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
the sparse.c and sscan.c files are now committed in src dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This isn't a Makefile target that I use, so I trust you know what's best here.
@pdowler There is intention to remove these files from the src directory and auto-generate it. Can such possible change break your rule? |
When I added that rule back in 1.1.x those files were generated in the base dir and it was the quick and dirty way to make a src tarball... wasn't the right choice back then. Now, it looks like the C files are in src and committed to git so that is no longer needed. If there is a change in future to not have those generated C files committed, then next time around I'll fix the rpm build setup instead so it can generate them correctly. I don't know the pros and cons of those files being committed to git... probably wouldn't have been my choice (minimalist)., but I don't intend to change that. |
the sparse.c and sscan.c files are now committed in src dir
I use the dist target to create tarballs as part of building rpm packages.