Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix build due to changes in PostgreSQL 16#64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MarinaPolyakova merged 3 commits intomasterfromPGPRO-7444
Nov 23, 2022

Conversation

@MarinaPolyakova
Copy link
Contributor

  1. See the commit 3057465acfbea2f3dd7a914a1478064022c6eecd (Replace the sorted
    array of GUC variables with a hash table.) in PostgreSQL 16.

  2. See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add
    -Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.

pg_wait_sampling.c: In function ‘pg_wait_sampling_get_current’:pg_wait_sampling.c:454:42: warning: declaration of ‘params’ shadows a previouslocal [-Wshadow=compatible-local]  454 |                 WaitCurrentContext      *params;      |                                          ^~~~~~pg_wait_sampling.c:446:34: note: shadowed declaration is here  446 |         WaitCurrentContext      *params;      |                                  ^~~~~~

Marina Polyakova added2 commitsNovember 21, 2022 17:38
See the commit 3057465acfbea2f3dd7a914a1478064022c6eecd (Replace the sortedarray of GUC variables with a hash table.) in PostgreSQL 16.
See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add-Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.pg_wait_sampling.c: In function ‘pg_wait_sampling_get_current’:pg_wait_sampling.c:454:42: warning: declaration of ‘params’ shadows a previouslocal [-Wshadow=compatible-local]  454 |                 WaitCurrentContext      *params;      |                                          ^~~~~~pg_wait_sampling.c:446:34: note: shadowed declaration is here  446 |         WaitCurrentContext      *params;      |                                  ^~~~~~
AssertArg and AssertState were removed in PostgreSQL by commit #b1099eca8f.
Copy link
Contributor

@rzharkovrzharkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Everything looks well.
While I'm at it I have replace AssertState with Assert.
Please take a look on my commit.

@MarinaPolyakova
Copy link
ContributorAuthor

MarinaPolyakova commentedNov 23, 2022•
edited
Loading

pg_wait_sampling is PostgreSQL extension which requires PostgreSQL 9.6 or higher.

I checked that:

  1. AssertState is almost the same as Assert inREL9_6_STABLE (c.h):
#ifndef USE_ASSERT_CHECKING#define Assert(condition)((void)true)#define AssertState(condition)((void)true)#elif defined(FRONTEND)#define Assert(p) assert(p)#define AssertState(condition) assert(condition)#else/* USE_ASSERT_CHECKING && !FRONTEND */#define Assert(condition) \Trap(!(condition), "FailedAssertion")#define AssertState(condition) \Trap(!(condition), "BadState")#endif   /* USE_ASSERT_CHECKING && !FRONTEND */
  1. Build and tests (= make installcheck after adding conf.add to $PGDATA/postgresql.conf) passed with USE_PGXS=1 withREL9_6_STABLE andmaster.

Thank you!

@MarinaPolyakovaMarinaPolyakova merged commit544a4ee intomasterNov 23, 2022
@MarinaPolyakovaMarinaPolyakova deleted the PGPRO-7444 branchNovember 23, 2022 08:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rzharkovrzharkovrzharkov left review comments

Assignees

@MarinaPolyakovaMarinaPolyakova

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarinaPolyakova@rzharkov@shinderuk
[8]ページ先頭
©2009-2025 Movatter.jp