NotificationsYou must be signed in to change notification settings
Fork41
Star164

Fix compatibility with new shm_mq_send API introduced in pg15.#39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

keremet merged 1 commit intopostgrespro:masterfromrjuju:fix_send_shm_mq

Mar 24, 2022

Merged

Fix compatibility with new shm_mq_send API introduced in pg15.#39

keremet merged 1 commit intopostgrespro:masterfromrjuju:fix_send_shm_mq

Mar 24, 2022

Conversation

Copy link

Contributor

rjuju commentedOct 23, 2021

Related upstream commit: 46846433a03dff4f2e08c8a161e54a842da360d6

maksm90 self-requested a review

March 22, 2022 15:33

maksm90 requested changes

Mar 22, 2022

View reviewed changes

collector.c OutdatedShow resolvedHide resolved

Copy link

Collaborator

Generally to avoid code mess around calling of core functions not compatible for different versions of PostgreSQL we try to hide this in specialcompat.c file and provide compatible version with suffixCompat() or_compat() depending on selected function naming convention in initial name.

Fix compatibility with new shm_mq_send API introduced in pg15.

77ba2ca

Related upstream commit: 46846433a03dff4f2e08c8a161e54a842da360d6

Copy link

ContributorAuthor

rjuju commentedMar 22, 2022

Hi@maksm90. Thanks for the review, I wasn't aware of this compat.c file.

I fixed-pushed-force accordingly (rjuju@77ba2ca), but github is somewhat broken again (https://www.githubstatus.com/incidents/83lq7ftk19r5) so it doesn't seem to have picked up the new commit here yet. It will probably eventually show up.