- Notifications
You must be signed in to change notification settings - Fork3
Bugfix/issue 38#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would remove this redundancy comment, otherwise it LGTM
pg_variables.c Outdated
| /* Nothing to do here if trans object was removed already. */ | ||
| if (dlist_is_empty(&object->states)) | ||
| { | ||
| /* Probably redundant. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why is it redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As far as I can see, the only way we can get here is if variable is already removed. So all the tests are ok just with return here.
No description provided.