- Notifications
You must be signed in to change notification settings - Fork2
Add xact support: bugfix#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedAug 5, 2018
Codecov Report
@@ Coverage Diff @@## master #12 +/- ##==========================================+ Coverage 94.28% 94.29% +<.01%========================================== Files 4 4 Lines 875 876 +1 ==========================================+ Hits 825 826 +1 Misses 50 50
Continue to review full report at Codecov.
|
| @@ -1260,7 +1260,7 @@ makePackHTAB(Package *package, bool is_trans) | |||
| ALLOCSET_DEFAULT_SIZES); | |||
| snprintf(hash_name, BUFSIZ, "%s variables hash for package \"%s\"", | |||
| is_trans ? "Transactional" : "Regular",key); | |||
| is_trans ? "Transactional" : "Regular",package->transObject.name); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Тут можно использовать макрос GetName().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Вообще да. Я уже и забыл про наличие макросов =)
Закоммитить? Или сам?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Закоммитил
Fixed package rollback and package HTAB naming.