NotificationsYou must be signed in to change notification settings
Fork6
Star16

Commitef4120f

Marina Polyakova

committed

PGPRO-6866: do not use the function pg_atoi if possible

In PostgreSQL version 12 or higher it's more effecient to use the functionpg_strtoint32 instead (see the commit 86eaf208ea048936df6be77276a246d3f92e9620).And in PostgreSQL 15 the function pg_atoi was removed altogether (see the commit73508475d69e90f98ebd9b7e1a5933a26a49c5e9). Therefore if possible use thefunction pg_strtoint32 instead.

1 parent9a911f7 commitef4120fCopy full SHA for ef4120f

File tree

1 file changed

-4

lines changed

tsparser.c

1 file changed

-4

lines changed

`‎tsparser.c`

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,10 @@ typedef struct TParser`
`269`	`269`	`inttype;`
`270`	`270`	`}TParser;`
`271`	`271`
	`272`	`+#ifPG_VERSION_NUM<120000`
	`273`	`+#definepg_strtoint32(value)pg_atoi((value), sizeof(int32), 0)`
	`274`	`+#endif`
	`275`	`+`
`272`	`276`
`273`	`277`	`/* forward decls here */`
`274`	`278`	`staticboolTParserGet(TParser*prs);`
`@@ -2533,13 +2537,13 @@ tsparser_headline(PG_FUNCTION_ARGS)`
`2533`	`2537`	`char*val=defGetString(defel);`
`2534`	`2538`
`2535`	`2539`	`if (pg_strcasecmp(defel->defname,"MaxWords")==0)`
`2536`		`-max_words=pg_atoi(val,sizeof(int32),0);`
	`2540`	`+max_words=pg_strtoint32(val);`
`2537`	`2541`	`elseif (pg_strcasecmp(defel->defname,"MinWords")==0)`
`2538`		`-min_words=pg_atoi(val,sizeof(int32),0);`
	`2542`	`+min_words=pg_strtoint32(val);`
`2539`	`2543`	`elseif (pg_strcasecmp(defel->defname,"ShortWord")==0)`
`2540`		`-shortword=pg_atoi(val,sizeof(int32),0);`
	`2544`	`+shortword=pg_strtoint32(val);`
`2541`	`2545`	`elseif (pg_strcasecmp(defel->defname,"MaxFragments")==0)`
`2542`		`-max_fragments=pg_atoi(val,sizeof(int32),0);`
	`2546`	`+max_fragments=pg_strtoint32(val);`
`2543`	`2547`	`elseif (pg_strcasecmp(defel->defname,"StartSel")==0)`
`2544`	`2548`	`prs->startsel=pstrdup(val);`
`2545`	`2549`	`elseif (pg_strcasecmp(defel->defname,"StopSel")==0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitef4120f

File tree

1 file changed

1 file changed

`‎tsparser.c`

0 commit comments