NotificationsYou must be signed in to change notification settings
Fork26
Star157

Fix compiler warnings due to new checks in PostgreSQL 16#43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

sokolcati merged 1 commit intomasterfromPGPRO-7444

Nov 24, 2022

Merged

Fix compiler warnings due to new checks in PostgreSQL 16#43

sokolcati merged 1 commit intomasterfromPGPRO-7444

Nov 24, 2022

Conversation

Copy link

MarinaPolyakova commentedNov 21, 2022

See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add -Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.

pg_query_state.c: In function ‘pg_query_state’:pg_query_state.c:615:66: warning: declaration of ‘msg’ shadows a previous local [-Wshadow=compatible-local]  615 |                                                 shm_mq_msg      *msg =(shm_mq_msg *) lfirst(i);      |                                                                  ^~~pg_query_state.c:489:42: note: shadowed declaration is here  489 |                 shm_mq_msg              *msg;      |                                          ^~~pg_query_state.c: In function ‘GetRemoteBackendWorkers’:pg_query_state.c:946:25: warning: declaration of ‘proc’ shadows a parameter[-Wshadow=compatible-local]  946 |                 PGPROC *proc = BackendPidGetProc(pid);      |                         ^~~~pg_query_state.c:913:33: note: shadowed declaration is here  913 | GetRemoteBackendWorkers(PGPROC *proc)      |                         ~~~~~~~~^~~~

Fix compiler warnings due to new checks in PostgreSQL 16

5ba8779

See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add-Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.pg_query_state.c: In function ‘pg_query_state’:pg_query_state.c:615:66: warning: declaration of ‘msg’ shadows a previous local[-Wshadow=compatible-local]  615 |                                                 shm_mq_msg      *msg =(shm_mq_msg *) lfirst(i);      |                                                                  ^~~pg_query_state.c:489:42: note: shadowed declaration is here  489 |                 shm_mq_msg              *msg;      |                                          ^~~pg_query_state.c: In function ‘GetRemoteBackendWorkers’:pg_query_state.c:946:25: warning: declaration of ‘proc’ shadows a parameter[-Wshadow=compatible-local]  946 |                 PGPROC *proc = BackendPidGetProc(pid);      |                         ^~~~pg_query_state.c:913:33: note: shadowed declaration is here  913 | GetRemoteBackendWorkers(PGPROC *proc)      |                         ~~~~~~~~^~~~

MarinaPolyakova requested a review fromsokolcati

November 21, 2022 13:57

MarinaPolyakova assignedsokolcati

Nov 21, 2022

Copy link

codecovbot commentedNov 21, 2022•
edited
Loading

Codecov Report

Merging#43 (d3285d6) intomaster (74f6c16) willincrease coverage by0.51%.
The diff coverage is57.14%.

❗ Current headd3285d6 differs from pull request most recent head5ba8779. Consider uploading reports for the commit5ba8779 to get more accurate results

@@            Coverage Diff             @@##           master      #43      +/-   ##==========================================+ Coverage   76.36%   76.88%   +0.51%==========================================  Files           9        9                Lines         694      636      -58     ==========================================- Hits          530      489      -41+ Misses        164      147      -17

Impacted Files	Coverage Δ
pg_query_state.c	`75.21% <57.14%> (+0.77%)`	⬆️
pg_bin/include/postgresql/server/port/atomics.h	`72.72% <0.00%> (-6.59%)`	⬇️
pg_bin/include/postgresql/server/utils/palloc.h	`100.00% <0.00%> (ø)`
pg_bin/include/postgresql/server/nodes/pg_list.h	`100.00% <0.00%> (ø)`
signal_handler.c	`82.53% <0.00%> (+1.62%)`	⬆️
...n/include/postgresql/server/port/atomics/generic.h	`75.00% <0.00%> (+8.33%)`	⬆️