Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added PGRPO13 support. Modify Makefile for run installcheck.#20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ololobus merged 7 commits intomasterfromPGPRO13_installcheck
May 11, 2021

Conversation

dlepikhova
Copy link
Contributor

The proposed patch fixed problems with PGRPO13 support. Also it modify Makefile for run installcheck and modify script for run tests in docker container.

Copy link
Contributor

@ololobusololobus left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks good to me. However, I am still getting two types of errors when running docker tests.

Assertion failure with basic python tests:

test when two backends compete with each other to extract state from third running backend...ok!test statistics under calling function...[(9429, 0, 'select * from n_join_foo_bar()', 'Function Scan on n_join_foo_bar (Current loop: actual rows=0, loop number=1)', None)]Traceback (most recent call last):  File "tests/pg_qs_test_runner.py", line 129, in <module>    main(args)  File "tests/pg_qs_test_runner.py", line 112, in main    test(conn_params)  File "/pg/testdir/tests/test_cases.py", line 122, in test_nested_call    assert len(qs) == 2 \AssertionError

And division by zero with TPC-DS:

Database is setup successfullyStarting stress testPreparing TPC-DS queries...Starting TPC-DS queries... 91% (94 of 103) |##############################################################################################################################################################                | Elapsed Time: 0:01:06 ETA:   0:00:06Traceback (most recent call last):  File "tests/pg_qs_test_runner.py", line 129, in <module>    main(args)  File "tests/pg_qs_test_runner.py", line 98, in main    tpcds.run_tpcds(conn_params)  File "/pg/testdir/tests/tpcds.py", line 107, in run_tpcds    common.wait(acon)  File "/pg/testdir/tests/common.py", line 17, in wait    state = conn.poll()psycopg2.errors.DivisionByZero: division by zero100% (103 of 103) |#############################################################################################################################################################################| Elapsed Time: 0:01:07 Time:  0:01:07

First one looks like a real issue to fix or at least we have to correct our expectations.

Second one looks like a problem with test infrastructure and does not actually lead to a test failure.

If you do not see any short way to fix these issues then it is probably a matter of another PR.

@ololobus
Copy link
Contributor

I did a small cleanup and squashed it with your initial commit, so please do agit pull --rebase locally

@ololobus
Copy link
Contributor

ololobus commentedApr 15, 2021
edited
Loading

I have just created#21 issue, so again, we can postpone fixing these errors if you do not have a quick solution on mind. So I am going to merge this one if you are not going to add/fix anything here,@dlepikhova

@codecov
Copy link

codecovbot commentedMay 7, 2021
edited
Loading

Codecov Report

Merging#20 (5a2486d) intomaster (1b095a1) willdecrease coverage by11.55%.
The diff coverage is66.29%.

❗ Current head5a2486d differs from pull request most recent headb492d62. Consider uploading reports for the commitb492d62 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@##           master      #20       +/-   ##===========================================- Coverage   88.66%   77.11%   -11.56%===========================================  Files           2        2                 Lines         503      568       +65     ===========================================- Hits          446      438        -8- Misses         57      130       +73
Impacted FilesCoverage Δ
signal_handler.c86.53% <55.55%> (-9.85%)⬇️
pg_query_state.c75.00% <70.96%> (-12.15%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatefeaebcd...b492d62. Read thecomment docs.

@ololobusololobus merged commitfa5c7c0 intomasterMay 11, 2021
@sokolcatisokolcati deleted the PGPRO13_installcheck branchFebruary 28, 2024 08:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ololobusololobusololobus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dlepikhova@ololobus

[8]ページ先頭

©2009-2025 Movatter.jp