NotificationsYou must be signed in to change notification settings
Fork91
Star761

Respect PATH in a pg_probackup binary check#564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

asavchkov merged 1 commit intomasterfromrespect-path

Nov 10, 2022

Merged

Respect PATH in a pg_probackup binary check#564

asavchkov merged 1 commit intomasterfromrespect-path

Nov 10, 2022

Conversation

Copy link

Contributor

asavchkov commentedNov 10, 2022

This modification allows one to set PGPROBACKUPBIN to a binary included in PATH.

Check pg_probackup binary in PATH

d7cc00b

asavchkov requested review fromBurus,funny-falcon andkulaginm

November 10, 2022 05:19

Burus approved these changes

Nov 10, 2022

View reviewed changes

Copy link

Contributor

Burus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

https://docs.python.org/3/library/shutil.html#shutil.which действительно все условия закрывает. Все равно нет уверенности, что это в будущем не сломается с какой-то другой версией питона.