- Notifications
You must be signed in to change notification settings - Fork86
Small fixes#546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Small fixes#546
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -361,6 +361,7 @@ main(int argc, char *argv[]) | |||
| elog(ERROR, "Version mismatch, pg_probackup binary with version '%s' " | |||
| "is launched as an agent for pg_probackup binary with version '%s'", | |||
| PROGRAM_VERSION, argv[2]); | |||
| remote_agent = true; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Я думаю тогда надо дочистить и упоминание условия в config_get_opt() (потому что в случае агента эта функция вроде и не вызывается).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
src/utils/file.c Outdated
| @@ -3381,9 +3384,9 @@ fio_communicate(int in, int out) | |||
| case FIO_GET_CRC32: | |||
| /* calculate crc32 for a file */ | |||
| if (hdr.arg == 1) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
А это условие разве остаётся корректным после введения битовых флагов в arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
! Спасибо!
Uh oh!
There was an error while loading.Please reload this page.
src/archive.c Outdated
| @@ -761,8 +761,8 @@ push_file_internal_gz(const char *wal_file_name, const char *pg_xlog_dir, | |||
| pg_crc32 crc32_dst; | |||
| /* TODO: what if one of them goes missing? */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
А что с этим комментарием? Он актуален?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Хороший вопрос: могут ли у нас под ногами удалить файл?
Думаю, пока можно "забить" и убрать комментарий.
В целом, даже если мы хотим передавать missing_ok=true , нужно различать "не существовавший" файл и файл с crc==0. Так что, придётся переделывать API.
kulaginm commentedOct 11, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
По поводу введения set_forkname: |
Рефакторинг инициализации pgFile выделен в отдельную задачу. |
test_basic_ptrack_truncate_replica - локально 20 минут гонял (~25 раз), ни разу не упал |
c68c788 to51a141cCompare
No description provided.