Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

REL_2_5-PBCKP-236#531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
avaness merged 20 commits intoREL_2_5fromREL_2_5-PBCKP-236
Oct 27, 2022
Merged

REL_2_5-PBCKP-236#531

avaness merged 20 commits intoREL_2_5fromREL_2_5-PBCKP-236
Oct 27, 2022

Conversation

avaness
Copy link
Contributor

@avanessavaness commentedSep 5, 2022•
edited
Loading

@funny-falcon please review

@avanessavaness changed the base branch frommaster toREL_2_5September 5, 2022 16:56
Copy link
Collaborator

@funny-falconfunny-falcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

В целом, хорошо.

Я попрошу учесть замечания, хоть они больше стилистические, чем по существу.

static bool check_certified()
{
return strstr(PGPRO_VERSION_STR, "(certified)") ||
strstr(PGPRO_VERSION_STR, ("(standard certified)"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

А зачем тут скобочки вокруг строки?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PGPRO_VERSION_STR выглядит как "PostgresPro 11.17.1 (certified) on x86_64-pc-linux-gnu, ...", скобочки отсюда, чтобы быть более strict.


for (int i = 0; i <compatibility_params_array_size; i+=2)
for (int i = 0; i <sizeof compatibility_params; i+=2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Было правильно, зря убрал.

{
if (compatibility_params[i].strval != NULL)
result_size += snprintf(compatibility_buf + result_size, compatibility_buf_size - result_size,
"%s=%s/n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Слэш в другую сторону. И ниже тоже.

"CREATE TABLE ultimate_question2 AS SELECT 42 AS answer")

# do delta catchup with remote pg_probackup agent with another postgres major version
# this DELTA backup should fail without PBCKP-236 patch.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

А тест не должен падать в любом случае? По крайней мере, кажется что с патчем-то он точно должен падать.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

должен, он вообще не должен срабатывать, так как ссылается на абсолютный путь на бинарь другой версии. мне не понятно почему CI не репортит это. на планерке спрошу гипотезы.

@avanessavaness changed the titleRel 2 5 pbckp 236REL_2_5-PBCKP-236Sep 29, 2022
@avanessavaness marked this pull request as ready for reviewSeptember 29, 2022 01:45
@avanessavaness merged commitf2df286 intoREL_2_5Oct 27, 2022
@BurusBurus added this to the2.5.9 milestoneNov 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@funny-falconfunny-falconfunny-falcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.

3 participants
@avaness@funny-falcon@Burus
[8]ページ先頭
©2009-2025 Movatter.jp