- Notifications
You must be signed in to change notification settings - Fork86
[PBCKP-129] change catchup logging levels#473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
INFO – common informationLOG – same as INFO + info about filesVERBOSE – same as LOG + info about block and SQL queries
MetalDream666 commentedMay 27, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Нашла следующие возможные исправленияПоменять elog(VERBOSE..) на LOG: src/restore.c src/merge.c src/backup.c src/dir.c src/archive.c Поменять elog(LOG..) на INFO (скорее всего): src/backup.c Поменять elog(INFO..) на что-то другое: src/util.c src/data.c |
Исправил по замечаниям ревью, внёс изменения и для других команд (не только для catchup) |
MetalDream666 commentedMay 30, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Новая партия предложенных правок(аналогичные сообщения стоят под VERBOSE) Поменять на VERBOSE (информация по блокам, тредам, WAL): src/backup.c src/data.c src/archive.c src/parsexlog.c src/stream.c src/data.c |
kulaginm commentedAug 2, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Посмотрел последний комментарий@MetalDream666 (и указанный там код), но ничего не стал менять в коде, по одной из двух встречающихся причин:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Окей, соглашусь. Перепровепила еще раз все сообщения, думаю, можно мерджить
* [PBCKP-129] change catchup logging level verbosity:INFO – common informationLOG – same as INFO + info about filesVERBOSE – same as LOG + info about block and SQL queries
* [PBCKP-129] change catchup logging level verbosity:INFO – common informationLOG – same as INFO + info about filesVERBOSE – same as LOG + info about block and SQL queries
* [PBCKP-129] change catchup logging level verbosity:INFO – common informationLOG – same as INFO + info about filesVERBOSE – same as LOG + info about block and SQL queries
No description provided.