- Notifications
You must be signed in to change notification settings - Fork91
Closed
Description
Hello !
I have some strange behavior of sequential pg_probackup executions.
postgres@server:~/backup-tools# ls /backup/postgresql/backup/wal/ | grep exampledbexampledbpostgres@server:~/backup-tools# ls /backup/postgresql/backup/backups/exampledbls: cannot access '/backup/postgresql/backup/backups/exampledb': No such file or directorypostgres@server:~/backup-tools# pg_probackup-11 add-instance -B /backup/postgresql/backup -D /data/postgresql --instance exampledb --remote-host postgres.example.com --remote-user postgresERROR: arclog_path '/backup/postgresql/backup/wal/exampledb' already existspostgres@server:~/backup-tools# ls /backup/postgresql/backup/backups/exampledbpostgres@server:~/backup-tools# postgres@server:~/backup-tools# pg_probackup-11 add-instance -B /backup/postgresql/backup -D /data/postgresql --instance exampledb --remote-host postgres.example.com --remote-user postgresERROR: instance '/backup/postgresql/backup/backups/exampledb' already existsSo I think this behavior is not idempotent. When we try to execute pg_probackup several times one after another pg_probackup not only raises different error messages but also create inventory in broken state.
I think that before making any changes to file system pg_probackup should validate all conditions that possibly can prevent to create instance inventory successfuly.
Thank you in advance.