Commitfd73b9c

committed

add TODO for WAL parsing

1 parent09accf7 commitfd73b9cCopy full SHA for fd73b9c

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1291,7 +1291,10 @@ RunXLogThreads(const char *archivedir, time_t target_time,`
`1291`	`1291`	`result= false;`
`1292`	`1292`	`}`
`1293`	`1293`	`thread_interrupted= false;`
`1294`		`-interrupted= false;`
	`1294`	`+`
	`1295`	`+// TODO: we must detect difference between actual error (failed to read WAL) and interrupt signal`
	`1296`	`+//if (interrupted)`
	`1297`	`+//elog(ERROR, "Interrupted during WAL parsing");`
`1295`	`1298`
`1296`	`1299`	`/* Release threads here, use thread_args only below */`
`1297`	`1300`	`pfree(threads);`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,10 @@`
`11`	`11`
`12`	`12`	`#include"thread.h"`
`13`	`13`
	`14`	`+/*`
	`15`	`+ * Global var used to detect error condition (not signal interrupt!) in threads,`
	`16`	`+ * so if one thread errored out, then others may abort`
	`17`	`+ */`
`14`	`18`	`boolthread_interrupted= false;`
`15`	`19`
`16`	`20`	`#ifdefWIN32`

Comments

(0)