Commitbaf8fc2

committed

optimize find_deepest_partition() for single tables

1 parentf1a62b3 commitbaf8fc2Copy full SHA for baf8fc2

File tree

-4

lines changed

-4

lines changed

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -885,7 +885,8 @@ modifytable_contains_fdw(List rtable, ModifyTable node)`
`885`	`885`
`886`	`886`	`/*`
`887`	`887`	`* Find a single deepest subpartition using quals.`
`888`		`- * Return InvalidOid if it's not possible.`
	`888`	`+ * It's always better to narrow down the set of tables to be scanned.`
	`889`	`+ * Return InvalidOid if it's not possible (e.g. table is not partitioned).`
`889`	`890`	`*/`
`890`	`891`	`staticOid`
`891`	`892`	`find_deepest_partition(Oidrelid,Indexrti,Expr*quals)`
`@@ -931,8 +932,13 @@ find_deepest_partition(Oid relid, Index rti, Expr *quals)`
`931`	`932`	`Oid*children=PrelGetChildrenArray(prel),`
`932`	`933`	`child=children[irange_lower(irange)];`
`933`	`934`
	`935`	`+/* Scan this partition */`
	`936`	`+result=child;`
	`937`	`+`
`934`	`938`	`/* Try to go deeper and see if there are subpartitions */`
`935`		`-result=find_deepest_partition(child,rti,quals);`
	`939`	`+child=find_deepest_partition(child,rti,quals);`
	`940`	`+if (OidIsValid(child))`
	`941`	`+result=child;`
`936`	`942`	`}`
`937`	`943`	`break;`
`938`	`944`
`@@ -943,8 +949,6 @@ find_deepest_partition(Oid relid, Index rti, Expr *quals)`
`943`	`949`	`/* Don't forget to close 'prel'! */`
`944`	`950`	`close_pathman_relation_info(prel);`
`945`	`951`	`}`
`946`		`-/* Otherwise, return this table */`
`947`		`-elseresult=relid;`
`948`	`952`
`949`	`953`	`returnresult;`
`950`	`954`	`}`

Comments

(0)