NotificationsYou must be signed in to change notification settings
Fork67
Star588

Commit389c807

committed

Adapt pg_pathman for PG 11.

I kinda lost interest to exorcise a couple of tests further in attempts to makethem pass on all supported versions and just added copies. These are * pathman_expressions now differs because planner converts ROW(Const, Const) to just Const of record type. * Same with pathman_rebuild_updates.I have removed inclusion of partition_filter.h in pg_compat.h in 9.5 as itcreated circular dependency hell. I think it is not worthwhile to fight with itsince the only thing actually needed was error message, which is used in thissingle place.Small typo fix in partitioning_test.py: con2.begin instead of con1.begin.Finally, run python tests with --failfast and --verbose options.

1 parentadfaa72 commit389c807Copy full SHA for 389c807

File tree

26 files changed

+799

-89

lines changed

26 files changed

+799

-89

lines changed

`‎expected/pathman_expressions.out`

Lines changed: 19 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,9 @@`
	`1`	`+/*`
	`2`	`+ * -------------------------------------------`
	`3`	`+ * NOTE: This test behaves differenly on < 11 because planner now turns`
	`4`	`+ * Row(Const, Const) into just Const of record type, apparently since 3decd150`
	`5`	`+ * -------------------------------------------`
	`6`	`+ */`
`1`	`7`	`\set VERBOSITY terse`
`2`	`8`	`SET search_path = 'public';`
`3`	`9`	`CREATE EXTENSION pg_pathman;`
`@@ -160,42 +166,38 @@ SELECT *, tableoid::REGCLASS FROM test_exprs.composite;`
`160`	`166`	`(3 rows)`
`161`	`167`
`162`	`168`	`EXPLAIN (COSTS OFF) SELECT * FROM test_exprs.composite WHERE (a, b)::test_exprs.composite < (21, 0)::test_exprs.composite;`
`163`		`-QUERY PLAN`
`164`		`-----------------------------------------------------------------------------------------------`
	`169`	`+ QUERY PLAN`
	`170`	`+------------------------------------------------------------------------------------`
`165`	`171`	`Append`
`166`	`172`	`-> Seq Scan on composite_1`
`167`	`173`	`-> Seq Scan on composite_2`
`168`	`174`	`-> Seq Scan on composite_3`
`169`		`- Filter: (ROW(a, b)::test_exprs.composite <ROW(21, '0'::text)::test_exprs.composite)`
	`175`	`+ Filter: (ROW(a, b)::test_exprs.composite <'(21,0)'::test_exprs.composite)`
`170`	`176`	`(5 rows)`
`171`	`177`
`172`	`178`	`EXPLAIN (COSTS OFF) SELECT * FROM test_exprs.composite WHERE (a, b) < (21, 0)::test_exprs.composite;`
`173`		`-QUERY PLAN`
`174`		`-------------------------------------------------------------------------`
	`179`	`+ QUERY PLAN`
	`180`	`+--------------------------------------------------------------`
`175`	`181`	`Append`
`176`	`182`	`-> Seq Scan on composite_1`
`177`		`- Filter: (ROW(a, b) <ROW(21, '0'::text)::test_exprs.composite)`
	`183`	`+ Filter: (ROW(a, b) <'(21,0)'::test_exprs.composite)`
`178`	`184`	`-> Seq Scan on composite_2`
`179`		`- Filter: (ROW(a, b) <ROW(21, '0'::text)::test_exprs.composite)`
	`185`	`+ Filter: (ROW(a, b) <'(21,0)'::test_exprs.composite)`
`180`	`186`	`-> Seq Scan on composite_3`
`181`		`- Filter: (ROW(a, b) <ROW(21, '0'::text)::test_exprs.composite)`
	`187`	`+ Filter: (ROW(a, b) <'(21,0)'::test_exprs.composite)`
`182`	`188`	`-> Seq Scan on composite_4`
`183`		`- Filter: (ROW(a, b) <ROW(21, '0'::text)::test_exprs.composite)`
	`189`	`+ Filter: (ROW(a, b) <'(21,0)'::test_exprs.composite)`
`184`	`190`	`(9 rows)`
`185`	`191`
`186`	`192`	`EXPLAIN (COSTS OFF) SELECT * FROM test_exprs.composite WHERE (a, b)::test_exprs.composite < (21, 0);`
`187`		`- QUERY PLAN`
`188`		`-----------------------------------------------------------------`
	`193`	`+QUERY PLAN`
	`194`	`+----------------------------------------------------------------------`
`189`	`195`	`Append`
`190`	`196`	`-> Seq Scan on composite_1`
`191`		`- Filter: (ROW(a, b)::test_exprs.composite < ROW(21, 0))`
`192`	`197`	`-> Seq Scan on composite_2`
`193`		`- Filter: (ROW(a, b)::test_exprs.composite < ROW(21, 0))`
`194`	`198`	`-> Seq Scan on composite_3`
`195`		`- Filter: (ROW(a, b)::test_exprs.composite < ROW(21, 0))`
`196`		`- -> Seq Scan on composite_4`
`197`		`- Filter: (ROW(a, b)::test_exprs.composite < ROW(21, 0))`
`198`		`-(9 rows)`
	`199`	`+ Filter: (ROW(a, b)::test_exprs.composite < '(21,0)'::record)`
	`200`	`+(5 rows)`
`199`	`201`
`200`	`202`	`DROP TABLE test_exprs.composite CASCADE;`
`201`	`203`	`NOTICE: drop cascades to 5 other objects`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit389c807

File tree

26 files changed

26 files changed

`‎expected/pathman_expressions.out`

0 commit comments