NotificationsYou must be signed in to change notification settings
Fork2
Star17

Commit0da9e3d

committed

replaced with constant references to avoid copying

Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>

1 parent2b5ad94 commit0da9e3dCopy full SHA for 0da9e3d

File tree

4 files changed

+14

-14

lines changed

blobstamper

4 files changed

+14

-14

lines changed

`‎blobstamper/stamp_enumerator.cpp`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,10 +26,10 @@`
`26`	`26`
`27`	`27`	`std::stringStampStrEnumerator::ExtractStr(std::shared_ptr<Blob> blob)`
`28`	`28`	`{`
`29`		`- std::vector<std::string> data =ExtractStrVector(blob);`
	`29`	`+conststd::vector<std::string>&data =ExtractStrVector(blob);`
`30`	`30`	`std::string res ="";`
`31`	`31`
`32`		`-for (std::string s : data)`
	`32`	`+for (conststd::string&s : data)`
`33`	`33`	`{`
`34`	`34`	`if (!res.empty())`
`35`	`35`	`{`

`‎blobstamper/stamp_json.cpp`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`PoolPickerStamp::PoolPickerStamp(std::vector<std::shared_ptr<StampBaseStr>> new_pool)`
`28`	`28`	`: pool{new_pool}`
`29`	`29`	`{`
`30`		`-for (auto stamp : pool)`
	`30`	`+for (constauto&stamp : pool)`
`31`	`31`	`{`
`32`	`32`	`std::weak_ptr<StampBaseStr> wp = stamp;`
`33`	`33`	`weak_pool.push_back(wp);`
`@@ -40,7 +40,7 @@ PoolPickerStamp::isRecursive()`
`40`	`40`	`if (is_recursive \|\| is_in_recursion)`
`41`	`41`	`returntrue;`
`42`	`42`	`is_in_recursion =true;`
`43`		`-for (auto stamp : weak_pool)`
	`43`	`+for (constauto&stamp : weak_pool)`
`44`	`44`	`{`
`45`	`45`	`if (stamp.lock()->isRecursive())`
`46`	`46`	`{`
`@@ -62,7 +62,7 @@ PoolPickerStamp::ExtractStr(std::shared_ptr<Blob> blob)`
`62`	`62`	`std::vector<std::weak_ptr<StampBaseStr>> target_pool;`
`63`	`63`	`std::vector<std::weak_ptr<StampBaseStr>> unbounded_pool;`
`64`	`64`
`65`		`-for (auto stamp_w : weak_pool)`
	`65`	`+for (constauto&stamp_w : weak_pool)`
`66`	`66`	`{`
`67`	`67`	`auto stamp = stamp_w.lock();`
`68`	`68`	`if (stamp->minSize() <= blob->Size())`
`@@ -91,7 +91,7 @@ PoolPickerStamp::minSize()`
`91`	`91`	`if (is_in_recursion)`
`92`	`92`	`return res;`
`93`	`93`	`is_in_recursion =true;/* Do not use isRecursive() inside as it uses same flag*/`
`94`		`-for(auto stamp : weak_pool)`
	`94`	`+for (constauto&stamp : weak_pool)`
`95`	`95`	`{`
`96`	`96`	`int candidat = stamp.lock()->minSize();`
`97`	`97`	`if (res > candidat)`
`@@ -111,7 +111,7 @@ PoolPickerStamp::maxSize()`
`111`	`111`	`if (is_recursive \|\| is_in_recursion)`
`112`	`112`	`return -1;`
`113`	`113`	`is_in_recursion =true;/* Do not use isRecursive() inside as it uses same flag*/`
`114`		`-for (auto stamp : weak_pool)`
	`114`	`+for (constauto&stamp : weak_pool)`
`115`	`115`	`{`
`116`	`116`	`int candidat = stamp.lock()->maxSize();`
`117`	`117`	`if (candidat == -1)`
`@@ -144,8 +144,8 @@ StampJSONString::ExtractStr(std::shared_ptr<Blob> blob)`
`144`	`144`	`std::string`
`145`	`145`	`StampJSONHashEl::ExtractStr(std::shared_ptr<Blob> blob)`
`146`	`146`	`{`
`147`		`- std::string n = stamp_name->ExtractStr(blob);`
`148`		`- std::string v = stamp_value->ExtractStr(blob);`
	`147`	`+conststd::string&n = stamp_name->ExtractStr(blob);`
	`148`	`+conststd::string&v = stamp_value->ExtractStr(blob);`
`149`	`149`	`return n +":" + v;`
`150`	`150`	`}`
`151`	`151`

`‎blobstamper/stamp_math_op.cpp`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ StampMathUnaryOp::ExtractStr(std::shared_ptr<Blob> blob)`
`29`	`29`	`std::string`
`30`	`30`	`StampMathBinaryOp::ExtractStr(std::shared_ptr<Blob> blob)`
`31`	`31`	`{`
`32`		`- std::vector<std::shared_ptr<Blob>> blobs =extract_internal(blob);`
	`32`	`+conststd::vector<std::shared_ptr<Blob>>&blobs =extract_internal(blob);`
`33`	`33`	`return (std::string)"(" + stamp1->ExtractStr(blobs[0]) +"" + op_name +"" + stamp2->ExtractStr(blobs[1]) +")";`
`34`	`34`	`}`
`35`	`35`

`‎blobstamper/stamp_text.cpp`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,10 @@ StampTextPulp::ExtractStr(std::shared_ptr<Blob> blob)`
`38`	`38`
`39`	`39`	`std::stringStampTextPulpWords::ExtractStr(std::shared_ptr<Blob> blob)`
`40`	`40`	`{`
`41`		`- std::vector<std::string> data =ExtractStrVector(blob);`
	`41`	`+conststd::vector<std::string>&data =ExtractStrVector(blob);`
`42`	`42`	`std::string res ="";`
`43`	`43`
`44`		`-for(std::string s : data)`
	`44`	`+for (conststd::string&s : data)`
`45`	`45`	`{`
`46`	`46`	`if (!res.empty())`
`47`	`47`	`{`
`@@ -54,10 +54,10 @@ std::string StampTextPulpWords::ExtractStr(std::shared_ptr<Blob> blob)`
`54`	`54`
`55`	`55`	`std::stringStampTextDictWords::ExtractStr(std::shared_ptr<Blob> blob)`
`56`	`56`	`{`
`57`		`- std::vector<std::string> data =ExtractStrVector(blob);`
	`57`	`+conststd::vector<std::string>&data =ExtractStrVector(blob);`
`58`	`58`	`std::string res ="";`
`59`	`59`
`60`		`-for(std::string s : data)`
	`60`	`+for (conststd::string&s : data)`
`61`	`61`	`{`
`62`	`62`	`if (!res.empty())`
`63`	`63`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit0da9e3d

File tree

4 files changed

4 files changed

`‎blobstamper/stamp_enumerator.cpp`

`‎blobstamper/stamp_json.cpp`

`‎blobstamper/stamp_math_op.cpp`

`‎blobstamper/stamp_text.cpp`

0 commit comments