NotificationsYou must be signed in to change notification settings
Fork54
Star463

Commita89b899

committed

Fixed one possible memory leak and added explicit initializers to the variables with non-trivial initialization.

1 parent7fff2be commita89b899Copy full SHA for a89b899

File tree

2 files changed

+12

-12

lines changed

2 files changed

+12

-12

lines changed

`‎cardinality_hooks.c`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ aqo_set_baserel_rows_estimate(PlannerInfo root, RelOptInfo rel)`
`124`	`124`	`doublepredicted;`
`125`	`125`	`Oidrelid;`
`126`	`126`	`List*relids;`
`127`		`-List*selectivities;`
	`127`	`+List*selectivities=NULL;`
`128`	`128`
`129`	`129`	`if (use_aqo\|\|learn_aqo)`
`130`	`130`	`selectivities=get_selectivities(root,rel->baserestrictinfo,0,`
`@@ -163,10 +163,10 @@ aqo_get_parameterized_baserel_size(PlannerInfo *root,`
`163`	`163`	`List*param_clauses)`
`164`	`164`	`{`
`165`	`165`	`doublepredicted;`
`166`		`-Oidrelid;`
`167`		`-List*relids;`
`168`		`-List*allclauses;`
`169`		`-List*selectivities;`
	`166`	`+Oidrelid=InvalidOid;`
	`167`	`+List*relids=NULL;`
	`168`	`+List*allclauses=NULL;`
	`169`	`+List*selectivities=NULL;`
`170`	`170`	`ListCell*l;`
`171`	`171`	`ListCell*l2;`
`172`	`172`	`intnargs;`
`@@ -239,7 +239,7 @@ aqo_set_joinrel_size_estimates(PlannerInfo root, RelOptInfo rel,`
`239`	`239`	`List*selectivities;`
`240`	`240`	`List*inner_selectivities;`
`241`	`241`	`List*outer_selectivities;`
`242`		`-List*current_selectivities;`
	`242`	`+List*current_selectivities=NULL;`
`243`	`243`
`244`	`244`	`if (use_aqo\|\|learn_aqo)`
`245`	`245`	`current_selectivities=get_selectivities(root,restrictlist,0,`
`@@ -302,7 +302,7 @@ aqo_get_parameterized_joinrel_size(PlannerInfo *root,`
`302`	`302`	`List*selectivities;`
`303`	`303`	`List*inner_selectivities;`
`304`	`304`	`List*outer_selectivities;`
`305`		`-List*current_selectivities;`
	`305`	`+List*current_selectivities=NULL;`
`306`	`306`
`307`	`307`	`if (use_aqo\|\|learn_aqo)`
`308`	`308`	`current_selectivities=get_selectivities(root,restrict_clauses,0,`

`‎machine_learning.c`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -116,17 +116,17 @@ OkNNr_predict(int matrix_rows, int matrix_cols,`
`116`	`116`	`if (idx[i]!=-1)`
`117`	`117`	`result+=targets[idx[i]]*w[i] /w_sum;`
`118`	`118`
`119`		`-pfree(w);`
`120`		`-pfree(distances);`
	`119`	`+if (result<0)`
	`120`	`+result=0;`
`121`	`121`
`122`	`122`	`/* this should never happen */`
`123`	`123`	`if (idx[0]==-1)`
`124`		`-return-1;`
	`124`	`+result=-1;`
`125`	`125`
	`126`	`+pfree(w);`
	`127`	`+pfree(distances);`
`126`	`128`	`pfree(idx);`
`127`	`129`
`128`		`-if (result<0)`
`129`		`-result=0;`
`130`	`130`	`returnresult;`
`131`	`131`	`}`
`132`	`132`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita89b899

File tree

2 files changed

2 files changed

`‎cardinality_hooks.c`

`‎machine_learning.c`

0 commit comments