NotificationsYou must be signed in to change notification settings
Fork54
Star463

Commit62b3945

committed

restore_selectivities: avoid links to restrictinfo selectivity field: it can be freed or changed externally

1 parentb3bb11f commit62b3945Copy full SHA for 62b3945

File tree

1 file changed

+14

-16

lines changed

postprocessing.c

1 file changed

+14

-16

lines changed

`‎postprocessing.c`

Lines changed: 14 additions & 16 deletions

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,6 @@ restore_selectivities(List clauselist, List relidslist, JoinType join_type,`
`176`	`176`	`intnargs;`
`177`	`177`	`int*args_hash;`
`178`	`178`	`int*eclass_hash;`
`179`		`-double*cur_sel;`
`180`	`179`	`intcur_hash;`
`181`	`180`	`intcur_relid;`
`182`	`181`
`@@ -191,30 +190,29 @@ restore_selectivities(List clauselist, List relidslist, JoinType join_type,`
`191`	`190`	`foreach(l,clauselist)`
`192`	`191`	`{`
`193`	`192`	`RestrictInforinfo= (RestrictInfo)lfirst(l);`
	`193`	`+Selectivity*cur_sel=NULL;`
`194`	`194`
`195`		`-cur_sel=NULL;`
`196`	`195`	`if (parametrized_sel)`
`197`	`196`	`{`
`198`	`197`	`cur_hash=get_clause_hash(rinfo->clause,nargs,`
`199`	`198`	`args_hash,eclass_hash);`
`200`	`199`	`cur_sel=selectivity_cache_find_global_relid(cur_hash,cur_relid);`
`201`		`-if (cur_sel==NULL)`
`202`		`-{`
`203`		`-if (join_type==JOIN_INNER)`
`204`		`-cur_sel=&rinfo->norm_selec;`
`205`		`-else`
`206`		`-cur_sel=&rinfo->outer_selec;`
`207`		`-}`
`208`	`200`	`}`
`209`		`-elseif (join_type==JOIN_INNER)`
`210`		`-cur_sel=&rinfo->norm_selec;`
`211`		`-else`
`212`		`-cur_sel=&rinfo->outer_selec;`
`213`	`201`
`214`		`-if (*cur_sel<0)`
`215`		`-*cur_sel=0;`
	`202`	`+if (cur_sel==NULL)`
	`203`	`+{`
	`204`	`+cur_sel=palloc(sizeof(double));`
	`205`	`+`
	`206`	`+if (join_type==JOIN_INNER)`
	`207`	`+*cur_sel=rinfo->norm_selec;`
	`208`	`+else`
	`209`	`+*cur_sel=rinfo->outer_selec;`
	`210`	`+`
	`211`	`+if (*cur_sel<0)`
	`212`	`+*cur_sel=0;`
	`213`	`+}`
`216`	`214`
`217`		`-Assert(cur_sel>0);`
	`215`	`+Assert(*cur_sel >=0);`
`218`	`216`
`219`	`217`	`lst=lappend(lst,cur_sel);`
`220`	`218`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit62b3945

File tree

1 file changed

1 file changed

`‎postprocessing.c`

0 commit comments