Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Nested components#975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
levkk merged 11 commits intomasterfromlevkk-commit-tool
Sep 3, 2023
Merged

Nested components#975

levkk merged 11 commits intomasterfromlevkk-commit-tool
Sep 3, 2023

Conversation

levkk
Copy link
Contributor

@levkklevkk commentedSep 2, 2023
edited
Loading

pgml-components

Nested components

Add support for creating components in subfolders ofsrc/components. This allows grouping components together, e.g.:

cargo pgml-components add component controls/buttoncargo pgml-components add component controls/dropdowncargo pgml-components add component popups/modalcargo pgml-components add component popups/tooltipcreated directory src/components/controls/buttonwritten src/components/controls/button/template.htmlwritten src/components/controls/button/button_controller.jswritten src/components/controls/button/mod.rswritten src/components/controls/button/button.scsswritten src/components/controls/mod.rswritten src/components/mod.rscreated directory src/components/controls/dropdownwritten src/components/controls/dropdown/template.htmlwritten src/components/controls/dropdown/dropdown_controller.jswritten src/components/controls/dropdown/mod.rswritten src/components/controls/dropdown/dropdown.scsswritten src/components/controls/mod.rscreated directory src/components/popups/modalwritten src/components/popups/modal/template.htmlwritten src/components/popups/modal/modal_controller.jswritten src/components/popups/modal/mod.rswritten src/components/popups/modal/modal.scsswritten src/components/popups/mod.rswritten src/components/mod.rscreated directory src/components/popups/tooltipwritten src/components/popups/tooltip/template.htmlwritten src/components/popups/tooltip/tooltip_controller.jswritten src/components/popups/tooltip/mod.rswritten src/components/popups/tooltip/tooltip.scsswritten src/components/popups/mod.rs

Bug fixes

  1. Prevents using Rust-reserved keywords in component names.
  2. Makes sure components can be created in their own folders only without breaking other components.

Misc

  1. Add more default code into the component templates to make them easier to find when added for the first time into the DOM.
    image

Tests

Added a few tests to cover basic use cases and help with regressions.

pgml-dashboard

  1. Added back dev-mode that reads from style.css and bundle.js instead of from the hashed files. This allows to not rebuild the app every time JS or CSS changes are made.

@levkklevkk marked this pull request as ready for reviewSeptember 3, 2023 22:21
@levkklevkk merged commitf8a1c4a intomasterSep 3, 2023
@levkklevkk deleted the levkk-commit-tool branchSeptember 3, 2023 22:23
SilasMarvin pushed a commit that referenced this pull requestOct 5, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@levkk

[8]ページ先頭

©2009-2025 Movatter.jp