- Notifications
You must be signed in to change notification settings - Fork352
Dan set user#697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Dan set user#697
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| }; | ||
| let shared_state =match request.guard::<&State<Clusters>>().await{ | ||
| let user_id:i64 =match cookies.get_private("user_id"){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| let user_id:i64 =match cookies.get_private("user_id"){ | |
| let user_id =match cookies.get_private("user_id"){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also we are setting this object in our closed source code, you don't need to fetch the cookie here. The cookie won't provide enough user information once we start adding more, e.g. email.
| let pool =shared_state.get(cluster_id); | ||
| let pool =clusters_shared_state.get(cluster_id); | ||
| let context =Context{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn'tContext an exported public struct of this app? If not, it should be, so we instantiate it and set it in our code.
In guards, get user from saved cookie rather than cluster owner. This ensures even if cluster is not chosen the user is known for rendering top nav.