Jun 5, 2023 · Jun 5, 2023 · Jun 5, 2023 · Jun 5, 2023 · Jun 5, 2023 · Jun 5, 2023
diff --git a/pgml-extension/src/bindings/transformers.py b/pgml-extension/src/bindings/transformers.py

 def embed(transformer, inputs, kwargs):

 if not isinstance(inputs, str):
 try:
        inputs = json.loads(inputs)
    except json.decoder.JSONDecodeError:
        pass

    kwargs = json.loads(kwargs)
    ensure_device(kwargs)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -112,8 +112,10 @@ def transform(task, args, inputs):

		def embed(transformer, inputs, kwargs):

		if not isinstance(inputs, str):
		try:
		inputs = json.loads(inputs)
		except json.decoder.JSONDecodeError:
Copy link Contributor montanalowJun 5, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. What is the known case that this is handling? Copy link ContributorAuthor jsaied99Jun 5, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Without passing any extra arguments, I couldn't think of a way of knowing wether inputs was a string or a JSON string. Thought the simplest way was trying to convert it into a python object.
		pass

		kwargs = json.loads(kwargs)
		ensure_device(kwargs)
Expand Down