More idiomatic, but doesn't matter.

Duplicate primary key technically, since this is unique. Curious why we can't use theid field as the document identifier?

Don't need to create an index here ondocument,UNIQUE does it already automatically. So I think you end up with two indexes on the same field.

UNIQUE (task, splitter, model) in the table definition creates a compound index on those three columns. Having 3 additional individual indexes on the same columns may not be necessary.

Are you sure you want toCASCADE? This has the effect of automatically deleting rows from this table when the row they are referencing in another table is deleted. This can delete a lot of data accidentally. The preferred way for me generally is toON DELETE RESTRICT which is the default. That way, you'll get an error when attempting to delete a splitter that's referenced by this table. This is default behavior also, so you can just removeON DELETE CASCADE.

Odd way of referencing another table, I've never seen that done before. Is this compatible with logical replication? I.e. if we want to move this data to another database, the oids probably won't match anymore, since they are specific to a Postgres installation.

This should probably be calledtable_name. Anoid is something very Postgres-specific and does not mean a table reference at all. In fact, it can reference a row in a TOAST table or a type inpg_type.

The convention is sometimes to usefield_id to explain to the reader that this refers to the primary key (usuallyid) column in another table. The reviewer would look in this case if the column being referenced has an index on it, which is often required for foreign keys: a foreign key validation needs to be an index scan, the quickest way to validate that this value exists in another table.

_id is not just a railsism, it's a popular and significant readability improvement to easily distinguish local fields from foreign keys, which isn't really Hungarian notation. It's part of what-this-field-represents, rather than what-data-type-is-this-field.

It's more similar to the convention many programming languages use by adding* or& to distinguish references and pointers from local objects on the stack.

A foreign key can be polymorphic, in which case, the naming convention suddenly becomes important. Sure, one can't really enforce naming conventions programmatically, but there is no reason to make something harder to understand.

For example,created_at can be renamed torandom_date and only by looking at the definition of the column one would realize that this is actually a creation timestamp, but we don't do that, we call itcreated_at because we want to be kind to our future selves and to reviewers and other users of our code. An argument can be made for calling variablesabcd and only by reading the code fully, one will truly understand what they do, but we don't do that either.

Rails can be many things that we don't agree with, but the way ActiveRecord handles data is fantastic, and we would be wise to learn from their experience and do something most engineers are familiar and happy to work with.

And you will commonly see code that is forced to name two variables in a context things likedocument_ptr and adocument , to disambiguate the one that has been dereferenced safely. No one would assume that the compiler checks_ptr correctness, but if they ever saw a variable with that extension, next to a variable without the extension, and the truth of the references disagreed with the conventions we've established match expectations, people would say the variable was misnamed and likely to cause bugs or confusion.

We write code for others to read. Code should consistently follow the conventions established in the project. The convention has already been established, and there is no need to revisit that convention, when the suggestion obviously confused multiple team members in multiple places due to not just inconsistency with the greater project scope, but inconsistency within the necessary layers to achieve a solution, and also inconsistency within a single table.

Natural joins withUSING is generally useless, because it uses all columns in common, not just the key. In this casecreated_at would be shared but would not be the same, so natural joins won't work.

NoteUSING is reasonably safe from column changes in the joined relations since only the listed columns are combined. NATURAL is considerably more risky since any schema changes to either relation that cause a new matching column name to be present will cause the join to combine that new column as well.

If you're still not convinced, there is theuser_uuid in your example, which is yet another instance.

But similarly, if you really want to useUSING, and not natural joins, it works just as well to call them bothdocument_id, and you can keep that feature of SQL.

Calling them bothdocument_id would also be a break with Rails conventions, though...

You seem confused about the importance of Rails conventions, and to be missing the point that this schema is not an island unto itself, nor is this SDK. The important aspect is that a database and schema in this context are useless without an application layer of logic on top. That application layer will have concerns with ORM that will be simpler to maintain if the database follows a convention of using_id prefixes. The reason you see the pattern replicated so widely, is because it's so frequently eases the mental burden of application developers. DBA's or people working only inside the database may not understand these concepts or concerns, but that doesn't mean they don't exist.

This would be more clear to me if the field name wasdocument_id to match the variable name. I was half expectingdocument to be a text value.

Right, so using one convention for names at one layer, and a different convention for names in the next layer down seems confusing, there is good reason to add_id in both layers.

Missing_id suffixes make this hard for me to read.

Yes,chunk_id is the chunk index for the given document text. For example: if the text "hello world" is split into two chunks then chunk_id 0 will map to "hello" and chunk_id 1 will map to "world".id is the global id of the chunk across all documents and splitters.

Yes, this is a perfect example of needing both a local and reference to the same "object" in a single context, and being forced to disambiguate one of them with an_id suffix. The confusing ones in this line aredocument, andsplitter.chunk andchunk_id are clear and easily distinguished, even thoughchunk_id does not in fact refer to a foreign key in achunks table, it's clearly marked as a reference.

chunk_id is the ordering of the chunk within the document.chunk_index sounds good.

_id is not just a railsism, it's a popular and significant readability improvement to easily distinguish local fields from foreign keys, which isn't really Hungarian notation. It's part of what-this-field-represents, rather than what-data-type-is-this-field.

It's more similar to the convention many programming languages use by adding* or& to distinguish references and pointers from local objects on the stack.

This needs to be refactored into the insert statement to avoid round tripping the vector.

I would include this with a CTE in the embeddings statement as well to avoid the round trip.

A query builder can be used for the CTE here.

This needs to be cached some how to avoid multiple round trips to the db for this function.

This needs to be embedded with all the results queries to avoid n+1 queries

Prefer joins in SQL to round trips from the app.

Hard delete is a bit of a footgun.

Yeah, we could have some archiving mechanism, which simply alters the schema toname + '_archive', and then enable delete or restore on archives.

Adding more storage space is cheap. Recovering lost data is expensive and scary.

Also, we should support "undo".

that's what I meant by "restore"

That does not guarantee people aren't still using the table, if they are ignoring the flag by using poorly written homegrown queries, which is a potentially desirable outcome for projects that outgrow simple SDK designs, and what to leverage the full expressive power of SQL.