- Notifications
You must be signed in to change notification settings - Fork328
fix for np.float32 serialization#589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
pgml-extension/Dockerfile.local Outdated
| @@ -11,7 +11,7 @@ RUN cat /etc/apt/sources.list | |||
| RUN apt-get update && apt-get install -y postgresql-pgml-14 | |||
| # Cache this, quicker | |||
| RUN pip3 install xgboost scikit-learn diptest torch lightgbm transformers datasets sentencepiece sentence_transformers sacremoses sacrebleu rouge | |||
| RUN pip3 install xgboost scikit-learn diptest torch lightgbm transformers datasets sentencepiece sentence_transformers sacremoses sacrebleu rouge protobuf | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we should not need protobuf, what requires that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Finbert model needs protobuf.
SELECTpgml.transform( inputs=> ARRAY['Stocks rallied and the British pound gained.','Stocks making the biggest moves midday: Nvidia, Palantir and more' ], task=>'{"task": "text-classification", "model": "ProsusAI/finbert" }'::JSONB)AS market_sentiment;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wow... that's... indicative of a whole new level... are they actually calling any rpcs, or are they just serializing in a round about way? I don't really care...
santiatpmlApr 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I could not reproduce the error I saw before without protobuf on two other machines. I checked the model folder in cache and I don't see any reference to protobuf. Looks like we don't need it.
Uh oh!
There was an error while loading.Please reload this page.
Added tests for transforms and moved tune to a different set.