- Notifications
You must be signed in to change notification settings - Fork328
Separate embedding kwargs into init kwargs and encode kwargs#1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
montanalow merged 2 commits intopostgresml:masterfromtomaarsen:sentence_transformers_init_kwargsJul 12, 2024
Merged
Separate embedding kwargs into init kwargs and encode kwargs#1555
montanalow merged 2 commits intopostgresml:masterfromtomaarsen:sentence_transformers_init_kwargsJul 12, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
470f2d3
to18be006
Compare18be006
to465f38d
CompareThanks for the PR. I've added our embedding tests to CI, since we generally don't run the whole transformers suite due to the model download times. Confirmed that |
Excellent, thank you for merging & writing some simple tests.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves#1169
Hello!
Pull Request overview
trust_remote_code
(e.g.pgml.embed trust_remote_code #1169)token
(previously only possible via an environment variable, which FYI is still the recommended approach for security)truncate_dim
.model_kwargs
/tokenizer_kwargs
/config_kwargs
. The first is most useful for inference, e.g. allowing loading models in lower precision for faster inference:model_kwargs={"torch_dtype": "bfloat16"}
.Details
This PR splits
kwargs
inpgml.embed
into two types of kwargs: formodel = SentenceTransformer(..., **kwargs)
and formodel.encode(..., **kwargs)
. This is currently done using a simple filter that checks for kwargs that are only (e.g.trust_remote_code
) or primarily (e.g.device
) relevant for the initialization.I want to give a big preface that I have not tested this (!). My bandwidth is a bit too small this week for that I'm afraid. Another note is that
model_kwargs
/tokenizer_kwargs
/config_kwargs
andtruncate_dim
were only introduced in Sentence Transformers v3.0.0, whereas this project seems to be on v2.7 still. (FYI: ST v3.0 does not introduce breaking changes for inference, so upgrading should be safe).