I'm not sure why a user would use that, and not just:

frompgmlimportCollection,Batchcollection=Collection("my_collection")# batch = Batch(collection, 25, {"merge": True})batch= []# await batch.upsert_documents([{"id": 1}]) # Doesn't upsert yetbatch.append({"id":1})foriinrange(23):# await batch.upsert_documents([{"id": i}]) # Doesn't upsert yetbatch.append({"id":i})# Upserts whatever is in the current batch# and appends the document to the next batch# await batch.upsert_documents([{"id": 1}])awaitcollection.upsert_documents(batch, {"merge":True})# Upserts the final batch# await batch.finish()

Oh I see the automatic handling of upserting after they hit the threshold is nice, but it is a bit confusing. I think most people in the Python world are used to using batching systems already built into the dataset they are operating on. For example:https://huggingface.co/docs/datasets/en/process#batch-processing Not saying we shouldn't add it, but maybe we should clarify the name to likeAutoBatchUpsert or something I'm not sure.

Why not use thebatch_size argument on Collection.upsert_documents for this functionality?

Python world are used to using batching systems already built into the dataset

Datasets are one of very many sources for data. For example, my use case that triggered the desire for this feature was streaming WET files from awarcio.archiveiterator.ArchiveIterator which seemingly doesn't have batching support built-in. This is not uncommon for most non-machine learning libraries and toolkits which people use to build regular web apps. Is it easy to write the batching logic yourself? Seemingly so, but it's really easy to forget to flush the last often incomplete batch when the source stream is complete, especially when you have to do it yourself, over and over, for each use case you have in your code.

Why not use thebatch_size argument on Collection.upsert_documents for this functionality?

batch_size doesn't handle the incomplete batch scenario, where a user insertslen(records) % batch_size != 0, hence the need forfinish() akaflush(). You have to tell the collection when you're done writing and no more records will be added to whatever incomplete batch it's been buffering.

Right, having to call flush/finish is only an issue because of this new API you’re introducing. The example Silas gave doesn’t have the issue.