Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

SDK - Added re-ranking into vector search#1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SilasMarvin merged 2 commits intomasterfromsilas-sdk-add-reranking
Jun 10, 2024

Conversation

SilasMarvin
Copy link
Contributor

No description provided.

"boost": 1.0
},
}
},
Copy link
ContributorAuthor

@SilasMarvinSilasMarvinJun 10, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@montanalow How does this "rerank" key look?

query is the text to compare against.
model is the model to use
num_documents_to_rerank are the number of results to return from vector search and rerank against before limiting it to thelimit parameter defined in the next section

montanalow reacted with thumbs up emoji
"rerank": {
"query": "Test document 2",
"model": "mixedbread-ai/mxbai-rerank-base-v1",
"num_documents_to_rerank": 100
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about calling this justlimit. Does llamaindex or transformers have a similarly named parameter name?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh sorry missed this before merging. I think it might be a little confusing if we make it limit as we already have a limit key, and this isn't actually the limit. We already defined limit with llama index to mean the final number of items returned, but I'm not sure if they or langchain use it elsewhere.

}
},
"rerank": {
"query": "Test document 2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems likequery is being repeated a few places in this example, which may be pretty typical. One enhancement would be to move the query string out and reuse it everywhere, and make passing specific sub clause query strings optional. Not a launch blocker though.

SilasMarvin reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Got it, I will think more on making that optional and reusing it, but will merge this and get it out in the meantime.

@SilasMarvinSilasMarvin merged commitc3a8514 intomasterJun 10, 2024
1 check passed
@SilasMarvinSilasMarvin deleted the silas-sdk-add-reranking branchJune 10, 2024 18:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@montanalowmontanalowmontanalow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SilasMarvin@montanalow

[8]ページ先頭

©2009-2025 Movatter.jp