- Notifications
You must be signed in to change notification settings - Fork328
A few Python fixes#1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
A few Python fixes#1471
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| @@ -0,0 +1,97 @@ | |||
| accelerate==0.30.1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm guessing these are linux python 3.12 requirements. Why not replace requirements.linux.txt with this, and document 3.12 as the Python version required, to avoid sprawling too much. These frozen requirements are for deployments/dockerfiles more than development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm guessing these are linux python 3.12 requirements.
Don't have to guess, it's in the PR description.
Why not replace requirements.linux.txt with this, and document 3.12 as the Python version required, to avoid sprawling too much.
ray doesn't run on Python 3.12 and above, which is required byvllm andpgml.transform_stream(). So we actually don't have full support for our extension in Python 3.12.
These frozen requirements are for deployments/dockerfiles more than development.
Well, we have to start somewhere. I need this to run on Python 3.12 locally since I've seen the light and now am using Arch with latest available Python version. Arch users now officially outnumber Ubuntu users, so ...there you go.
Uh oh!
There was an error while loading.Please reload this page.
pgml.train(),pgml.embed(),pgml.transform(),pgml.chunk().