Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dan product left nav update#1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chillenberger merged 23 commits intomasterfromdan-product-left-nav-update
May 13, 2024
Merged

Conversation

chillenberger
Copy link
Contributor

@chillenbergerchillenberger commentedMay 7, 2024
edited
Loading

  • Product left nav expands on hover
  • Left nave now permanent, smoother and maintains state on content area change.
  • Move engine dropdown to topnav
  • default breadcrumb to home
  • remove breadcrumb on mobile
  • remove Product lower nav and account management
  • reduce dropdown height in topnav
  • reduce icon sizes
  • update left nav on content area nav
  • fix ttf 400 error
  • remove left nav border, darken top nav border
  • change dashboard to home
  • reset dropdown on breadcrumb nav
  • add engine info to mobile dropdown

Feedback will be added in another PR

Screen.Recording.2024-05-07.at.12.51.38.PM.1.mov

pub mod snapshots;
pub mod uploader;

#[get("/deployments")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This conflicts with our cloud route.

Copy link
ContributorAuthor

@chillenbergerchillenbergerMay 10, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is not new code, I just moved all the deployment/engine stuff out of lib.rs and into an organized file structure. We add /dashboard to the front. So the actual url is /dashboard/deployments, soon to be /engine/deployments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Right, sorry. Been a while since I looked at this code.

@chillenbergerchillenberger marked this pull request as ready for reviewMay 13, 2024 18:42
@chillenbergerchillenberger merged commit5ce41e7 intomasterMay 13, 2024
@chillenbergerchillenberger deleted the dan-product-left-nav-update branchMay 13, 2024 19:53
chillenberger added a commit that referenced this pull requestMay 13, 2024
@chillenbergerchillenberger restored the dan-product-left-nav-update branchMay 14, 2024 17:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@levkklevkklevkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@chillenberger@levkk

[8]ページ先頭

©2009-2025 Movatter.jp