- Notifications
You must be signed in to change notification settings - Fork328
Onboarding components fixes#1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
d77a08556f8d5b288b930119c20e52f6f588e0edddab123451e58f5f1356a7a7c33e42d88f3d5c2e4efcf8b614439f901cb7c6cad6d1b89ec81672aba0ecabd7adb48e1f4fc3e569e9fc26fde7821c3936b353164879161abf06fe8ea6cefFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| span[data-controller="headings-gray"] { | ||
| color: #{$gray-400}; | ||
| } | ||
Comment on lines +1 to +3 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. You could add color = gray-400 to the typography.scss file and just use the class here. Utility classes for the gray scale is always nice. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| use sailfish::TemplateOnce; | ||
| use pgml_components::component; | ||
| #[derive(TemplateOnce, Default)] | ||
| #[template(path = "headings/gray/template.html")] | ||
| pub struct Gray { | ||
| value: String, | ||
| } | ||
| impl Gray { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. If we want to go down this road, maybe one heading that takes a color, or has a setter function for the desired color, rather than a new component for every header. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Yeah I agree, these are too small to be individual components. | ||
| pub fn new(value: impl ToString) -> Gray { | ||
| Gray { | ||
| value: value.to_string(), | ||
| } | ||
| } | ||
| } | ||
| component!(Gray); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <span | ||
| data-controller="headings-gray"> | ||
| <%= value %> | ||
| </span> |