Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dan doc landing page#1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chillenberger merged 29 commits intomasterfromdan-doc-landing-page
Feb 20, 2024
Merged

Dan doc landing page#1320

chillenberger merged 29 commits intomasterfromdan-doc-landing-page
Feb 20, 2024

Conversation

chillenberger
Copy link
Contributor

  • Create Docs landing page
  • New Docs article page
  • Change look of scrollbar
  • Remove index from careers and blogs
  • Redesigen TOC

levkk reacted with rocket emoji
… alt marketing top nav style, bookmark progress.
@montanalow
Copy link
Contributor

Now that we're indexing all docs/blogs premptively, is it easy to build the index page urls without the trailing/? The reason I added that/ in the first place was to prevent having to check on disk if it was a file or directory before appending theREADME.md name. If we can avoid the extra check now, it'd be nice to be consistent.

@chillenberger
Copy link
ContributorAuthor

Now that we're indexing all docs/blogs premptively, is it easy to build the index page urls without the trailing/? The reason I added that/ in the first place was to prevent having to check on disk if it was a file or directory before appending theREADME.md name. If we can avoid the extra check now, it'd be nice to be consistent.

When the user navigates to a doc url we still use the url path to build the file path in the get_content_path method. We can't get away from the check now. We could do what your asking, but it's not trivial enough to throw into this PR.

@chillenbergerchillenberger merged commitb444b82 intomasterFeb 20, 2024
@chillenbergerchillenberger deleted the dan-doc-landing-page branchFebruary 20, 2024 20:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@chillenberger@montanalow

[8]ページ先頭

©2009-2025 Movatter.jp