- Notifications
You must be signed in to change notification settings - Fork328
fix doctype#1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix doctype#1300
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@chillenberger I see your PR around this too, thought it'd be able to fix than report the missing |
chillenberger commentedJan 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I was thinking about just using the tools from Pathbuf to determine if it is doc, blog, or careers. |
Could also pass in the collection to avoid having to parse at all. Or makethis a collection method. …On Tue, Jan 23, 2024 at 12:09 PM Dan ***@***.***> wrote: I was thinking about just using the tools from Pathbuf to determine if it is doc, blog, or careers. let doc_type = match path.strip_prefix(config::cms_dir()) { Ok(path) => { match path.into_iter().next() { Some(dir) => { match &PathBuf::from(dir).display().to_string()[..] { "blog" => Some(DocType::Blog), "docs" => Some(DocType::Docs), "careers" => Some(DocType::Careers), _ => None } }, _ => None } }, _ => None, }; — Reply to this email directly, view it on GitHub <#1300 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACDNHJ7OKIER2Z3XU7HHITYQAKIBAVCNFSM6AAAAABCHS6X2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWHA2DCNBUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***> |
It felt too specific to the doc to put in collection and I wanted to minimize the amount of info the caller needed since I wasn't sure what Silas would have access too. Here is what I am thinking#1301 |
No description provided.