Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix doctype#1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
montanalow wants to merge1 commit intomasterfrommontana/share
Closed

fix doctype#1300

montanalow wants to merge1 commit intomasterfrommontana/share

Conversation

montanalow
Copy link
Contributor

No description provided.

@montanalow
Copy link
ContributorAuthor

@chillenberger I see your PR around this too, thought it'd be able to fix than report the missing/ in both the regex and url.

@chillenberger
Copy link
Contributor

chillenberger commentedJan 23, 2024
edited
Loading

I was thinking about just using the tools from Pathbuf to determine if it is doc, blog, or careers.
let doc_type = match path.strip_prefix(config::cms_dir()) { Ok(path) => { match path.into_iter().next() { Some(dir) => { match &PathBuf::from(dir).display().to_string()[..] { "blog" => Some(DocType::Blog), "docs" => Some(DocType::Docs), "careers" => Some(DocType::Careers), _ => None } }, _ => None } }, _ => None, };
I am working on a pr for this now.

@montanalow
Copy link
ContributorAuthor

montanalow commentedJan 23, 2024 via email

Could also pass in the collection to avoid having to parse at all. Or makethis a collection method.
On Tue, Jan 23, 2024 at 12:09 PM Dan ***@***.***> wrote: I was thinking about just using the tools from Pathbuf to determine if it is doc, blog, or careers. let doc_type = match path.strip_prefix(config::cms_dir()) { Ok(path) => { match path.into_iter().next() { Some(dir) => { match &PathBuf::from(dir).display().to_string()[..] { "blog" => Some(DocType::Blog), "docs" => Some(DocType::Docs), "careers" => Some(DocType::Careers), _ => None } }, _ => None } }, _ => None, }; — Reply to this email directly, view it on GitHub <#1300 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACDNHJ7OKIER2Z3XU7HHITYQAKIBAVCNFSM6AAAAABCHS6X2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWHA2DCNBUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

@chillenberger
Copy link
Contributor

It felt too specific to the doc to put in collection and I wanted to minimize the amount of info the caller needed since I wasn't sure what Silas would have access too. Here is what I am thinking#1301

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chillenbergerchillenbergerAwaiting requested review from chillenberger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@montanalow@chillenberger

[8]ページ先頭

©2009-2025 Movatter.jp