Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023 · Dec 20, 2023
diff --git a/pgml-dashboard/src/api/cms.rs b/pgml-dashboard/src/api/cms.rs
        let rsp = req.dispatch().await;

        assert!(
            rsp.status() == Status::NotFound,
            rsp.status() == Status::Ok,
            "Returned status {:?}",
            rsp.status()
        );
Original file line number	Diff line number	Diff line change
Expand Up		@@ -550,7 +550,7 @@ This is the end of the markdown
		let rsp = req.dispatch().await;

		assert!(
		rsp.status() == Status::NotFound,
		rsp.status() == Status::Ok,
Copy link Contributor levkkDec 20, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should be 404 when doc not found. If we return ok, google will index the not found page and real and pollute the search index. Copy link ContributorAuthor chillenbergerDec 20, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Ok, I can switch it back. We will have to wait on keeping the lefthand nav on bad path then. Copy link Contributor levkkDec 20, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I don't understand what the connection between this and the leftnav is with the current context. Copy link ContributorAuthor chillenbergerDec 20, 2023• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. After a bad path Montana would like the other docs there on the left so the user can easy navigate away from the 404 response. Copy link Contributor levkkDec 21, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Ah I see, you'll just need a custom 404 page for the docs instead of using the default one. You can set that up with a 404 catcher in rocket.
		"Returned status {:?}",
		rsp.status()
		);
Expand Down