- Notifications
You must be signed in to change notification settings - Fork328
should be ok not 400#1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
should be ok not 400#1251
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chillenberger commentedDec 20, 2023
- Change test after changing behavior of docs bad path.
| @@ -550,7 +550,7 @@ This is the end of the markdown | |||
| let rsp = req.dispatch().await; | |||
| assert!( | |||
| rsp.status() == Status::NotFound, | |||
| rsp.status() == Status::Ok, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be 404 when doc not found. If we return ok, google will index the not found page and real and pollute the search index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, I can switch it back. We will have to wait on keeping the lefthand nav on bad path then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't understand what the connection between this and the leftnav is with the current context.
chillenbergerDec 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
After a bad path Montana would like the other docs there on the left so the user can easy navigate away from the 404 response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah I see, you'll just need a custom 404 page for the docs instead of using the default one. You can set that up with a 404 catcher in rocket.