Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Python & JavaScript CLI#1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SilasMarvin merged 9 commits intomasterfromlevkk-python-cli
Dec 2, 2023
Merged

Python & JavaScript CLI#1201

SilasMarvin merged 9 commits intomasterfromlevkk-python-cli
Dec 2, 2023

Conversation

levkk
Copy link
Contributor

@levkklevkk commentedNov 28, 2023
edited
Loading

  1. Add Python CLI.
  2. Add JavaScript CLI in a separate package because npm doesn't allow a package to contain a module and a binary at the same time.
  3. The CLI has just one command:connect, which creates a Postgres FDW connection from a PostgresML db to another PostgreSQL database.
  4. AddedPGML_CHECKOUT_TIMEOUT environment variable to control how long we wait for a connection in the SDK pool. Default: 5 seconds. This includes connect timeout for new pools.
  5. cargo fmt.

SilasMarvin reacted with rocket emoji
@montanalow
Copy link
Contributor

Why not Rust? Binary distributable would make life easier.

@levkk
Copy link
ContributorAuthor

Why not Rust? Binary distributable would make life easier.

Thought about it. The easiest way to distribute a CLI in the Rust world is withcargo install, which requires people to have the Rust toolchain installed. Conversely, if we use our SDK as the distribution vehicle, our CLI is now available to everyone who's using our SDK already in whatever language they choose.

@montanalow
Copy link
Contributor

Right, but we'd have to implement it in each language to accomplish what you're stating with this Python first approach. This method excludes Rust & JS, whereas we could follow the same Rust first method, and get Python/JS distribution for relatively free with the same behavior on all runtimes.

@montanalow
Copy link
Contributor

i.e. all SDKs should have a CLI, and the logic for the CLI should be implemented in the core Rust version.

@levkk
Copy link
ContributorAuthor

Take a look at the PR, the pieces are all there. The only reason I scoped this to Python is because I know how to make the module callable. In JS, I need to do some research.

montanalow reacted with laugh emoji

@levkklevkk changed the titlePython CLIPython & JavaScript CLINov 30, 2023
@SilasMarvinSilasMarvin merged commita7f9a0f intomasterDec 2, 2023
@SilasMarvinSilasMarvin deleted the levkk-python-cli branchDecember 2, 2023 00:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SilasMarvinSilasMarvinAwaiting requested review from SilasMarvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@levkk@montanalow@SilasMarvin

[8]ページ先頭

©2009-2025 Movatter.jp