NotificationsYou must be signed in to change notification settings
Fork328
Star6.4k

Mutable SQL commands should be used with Spi::update().#1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

montanalow merged 1 commit intopostgresml:masterfromhiguoxing:fix-spi-call

Oct 23, 2023

Merged

Mutable SQL commands should be used with Spi::update().#1114

montanalow merged 1 commit intopostgresml:masterfromhiguoxing:fix-spi-call

Oct 23, 2023

Conversation

Copy link

Contributor

higuoxing commentedOct 23, 2023•
edited
Loading

Commands like 'INSERT', 'CREATE TABLE' are modifying database objects. They should be used with 'Spi::update()'¹².

Besides, one of the unnecessary calling of '.clone()' is removed.

Co-Authored-By: Chen Mulongchenmulong@gmail.com

Footnotes

Mutable SQL commands should be used in Spi::update().

f95b897

Commands like 'INSERT', 'CREATE TABLE' are modifying database objects.They should be used in 'Spi::update()'[1][2].Besides, one of the unnecessary calling of '.clone()' is removed.[1]:https://www.postgresql.org/docs/current/spi-spi-execute.html[2]:https://github.com/pgcentralfoundation/pgrx/blob/64fbc2e2efb06212046082ffcde2e794ccb4d48a/pgrx/src/spi/client.rs#L60Co-Authored-By: Chen Mulong <chenmulong@gmail.com>