Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

2.7.12#1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
montanalow merged 1 commit intomasterfrommontana/2.7.12
Oct 21, 2023
Merged

2.7.12#1107

Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion.github/workflows/ubuntu-packages-and-docker-image.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ on:
workflow_dispatch:
inputs:
packageVersion:
default: "2.7.10"
default: "2.7.12"
jobs:
#
# PostgresML extension.
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ on:
workflow_dispatch:
inputs:
packageVersion:
default: "2.7.10"
default: "2.7.12"

jobs:
postgresml-python:
Expand Down
2 changes: 1 addition & 1 deletionREADME.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ docker run \
-v postgresml_data:/var/lib/postgresql \
-p 5433:5432 \
-p 8000:8000 \
ghcr.io/postgresml/postgresml:2.7.4 \
ghcr.io/postgresml/postgresml:2.7.12 \
sudo -u postgresml psql -d postgresml
```

Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresml-dashboard/build.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ dir="/tmp/postgresml-dashboard"
deb_dir="$dir/deb-build"
source_dir="$dir/source"
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
export PACKAGE_VERSION=${1:-"2.7.4"}
export PACKAGE_VERSION=${1:-"2.7.12"}
export GITHUB_STARS=$(curl -s "https://api.github.com/repos/postgresml/postgresml" | grep stargazers_count | cut -d : -f 2 | tr -d " " | tr -d ",")
if [[ $(arch) == "x86_64" ]]; then
export ARCH=amd64
Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresml-dashboard/release.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
package_version="$1"

if [[ -z "$package_version" ]]; then
echo "Usage: $0 <package version, e.g. 2.7.4>"
echo "Usage: $0 <package version, e.g. 2.7.12>"
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresml-python/build.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
deb_dir="/tmp/postgresml-python/deb-build"
major=${1:-"14"}

export PACKAGE_VERSION=${1:-"2.7.10"}
export PACKAGE_VERSION=${1:-"2.7.12"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You don't need to release a new version of this package unless you've changed python deps since the last version.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems like a nice convenience for end users, if all package versions for the project align.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's not how this works or why we split the python deps into their own package. This allows for us to upgrade the extension much quicker without having to download and install gigabytes of dependencies.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That split is causing issues with consistent updates.

Copy link
Contributor

@levkklevkkOct 21, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We have infrastructure in place to manage that. It wasn't used, which caused the issue with consistent updates. We can make it mandatory by bundling everything into the same package, but we've done that previously and it was pretty inefficient for rolling updates.

An action item on my side is to document the current infrastructure and provide guidebooks on how to upgrade and release these packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As I wrote the docs I remembered a couple more reasons why I split those packages and I'm pretty confident in my decision now. On thepostgresml/postgresml side of things, we're pretty covered I think, as long as we follow release procedures (#1013 (comment))

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Having code that implements the procedure seems like the next step after a manual procedure is documented.

export PYTHON_VERSION=${2:-"3.10"}

if [[ $(arch) == "x86_64" ]]; then
Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresml-python/release.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ fi

if [[ -z "$package_version" ]]; then
echo "postgresml-python package build and release script"
echo "usage: $0 <package version, e.g. 2.7.4>"
echo "usage: $0 <package version, e.g. 2.7.12>"
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresml/DEBIAN/control
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ Version: ${PACKAGE_VERSION}
Section: database
Priority: optional
Architecture: all
Depends: postgresml-python (>= 2.7.10), postgresql-pgml-${PGVERSION} (>= ${PACKAGE_VERSION})
Depends: postgresml-python (>= 2.7.12), postgresql-pgml-${PGVERSION} (>= ${PACKAGE_VERSION})
Maintainer: PostgresML <team@postgresml.org>
Homepage: https://postgresml.org
Description: PostgresML - Generative AI and Simple ML inside PostgreSQL
Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresml/build.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ set -e

SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

export PACKAGE_VERSION=${1:-"2.7.10"}
export PACKAGE_VERSION=${1:-"2.7.12"}
export PGVERSION=${2:-"14"}

deb_dir="/tmp/postgresml/deb-build"
Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresml/release.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ package_version="$1"

if [[ -z "$package_version" ]]; then
echo "postgresml package build and release script"
echo "usage: $0 <package version, e.g. 2.7.4>"
echo "usage: $0 <package version, e.g. 2.7.12>"
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletionpackages/postgresql-pgml/release.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ set -e
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

if [[ -z "${1}" ]]; then
echo "Usage: $0 <package version, e.g. 2.7.4>"
echo "Usage: $0 <package version, e.g. 2.7.12>"
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletionpgml-dashboard/content/docs/guides/setup/developers.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -127,7 +127,7 @@ SELECT pgml.version();
postgres=# select pgml.version();
version
-------------------
2.7.4
2.7.12
(1 row)
```

Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ docker run \
-v postgresml_data:/var/lib/postgresql \
-p 5433:5432 \
-p 8000:8000 \
ghcr.io/postgresml/postgresml:2.7.3 \
ghcr.io/postgresml/postgresml:2.7.12 \
sudo -u postgresml psql -d postgresml
```

Expand All@@ -44,7 +44,7 @@ docker run \
--gpus all \
-p 5433:5432 \
-p 8000:8000 \
ghcr.io/postgresml/postgresml:2.7.3 \
ghcr.io/postgresml/postgresml:2.7.12 \
sudo -u postgresml psql -d postgresml
```

Expand DownExpand Up@@ -82,7 +82,7 @@ Time: 41.520 ms
postgresml=# SELECT pgml.version();
version
---------
2.7.3
2.7.12
(1 row)
```

Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -135,7 +135,7 @@ CREATE EXTENSION
pgml_test=# SELECT pgml.version();
version
---------
2.7.4
2.7.12
(1 row)
```

Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,6 +115,6 @@ Type "help" for help.
postgresml=> SELECT pgml.version();
version
---------
2.7.9
2.7.12
(1 row)
```
2 changes: 1 addition & 1 deletionpgml-docs/docs/guides/developer-docs/contributing.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,7 +126,7 @@ SELECT pgml.version();
postgres=# select pgml.version();
version
-------------------
2.7.4
2.7.12
(1 row)
```

Expand Down
2 changes: 1 addition & 1 deletionpgml-docs/docs/guides/developer-docs/installation.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -133,7 +133,7 @@ CREATE EXTENSION
pgml_test=# SELECT pgml.version();
version
---------
2.7.4
2.7.12
(1 row)
```

Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,7 @@ docker run \
-v postgresml_data:/var/lib/postgresql \
-p 5433:5432 \
-p 8000:8000 \
ghcr.io/postgresml/postgresml:2.7.3 \
ghcr.io/postgresml/postgresml:2.7.12 \
sudo -u postgresml psql -d postgresml
```

Expand All@@ -43,7 +43,7 @@ docker run \
--gpus all \
-p 5433:5432 \
-p 8000:8000 \
ghcr.io/postgresml/postgresml:2.7.3 \
ghcr.io/postgresml/postgresml:2.7.12 \
sudo -u postgresml psql -d postgresml
```

Expand DownExpand Up@@ -80,7 +80,7 @@ Time: 41.520 ms
postgresml=# SELECT pgml.version();
version
---------
2.7.3
2.7.12
(1 row)
```

Expand Down
2 changes: 1 addition & 1 deletionpgml-extension/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

2 changes: 1 addition & 1 deletionpgml-extension/Cargo.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
[package]
name = "pgml"
version = "2.7.11"
version = "2.7.12"
edition = "2021"

[lib]
Expand Down
View file
Open in desktop
Empty file.
[8]ページ先頭
©2009-2025 Movatter.jp