- Notifications
You must be signed in to change notification settings - Fork328
add options capability to range input, add typography to site, fix sw…#1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chillenberger commentedOct 19, 2023
- Typography for site
- Add options to range input
- Center text in switch input
…itch centering content
| // .h6 {font-weight: 700; font-size: 24px; line-height: 30px;} | ||
| .h1-big { | ||
| font-weight: $font-weight-bold; font-size: 80px; line-height: 84px; | ||
| @include media-breakpoint-down(md) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this right? I remember last time we did this, the fonts were too small on mobile, not too big.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe you're also looking for "display" classes which are the headers but "big":https://getbootstrap.com/docs/5.3/content/typography/#display-headings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
On another note, I don't think we should be using pixels anymore, but rems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No before they were too big on mobile. I'll send you the slack conversation.
chillenbergerOct 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Honestly this can be redone the bootstap way (setitng the scss variables). Unfortunately some of the measurements in rem are pretty ugly fractions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should adjust our typography accordingly I think. Pixels are not responsive if I remember correctly, that's why the industry switched to ems and then to rems. I could be wrong about the reasoning, but I'm pretty certain everyone uses rems these days.