- Notifications
You must be signed in to change notification settings - Fork328
Chatbot page is almost ready to go#1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| }); | ||
| impl Star { | ||
| pub fn new<S: ToString, I: Into<Option<S>>>(color: &str, content: S, id: I) -> Star { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I discovered this the other day:
fn something(content: impl ToString)Seems cleaner than a generic notation.
| @@ -0,0 +1,13 @@ | |||
| import { Controller } from '@hotwired/stimulus' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can delete empty controllers, bundle just won't include them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes I just removed this!
| toastElement.setAttribute('role', 'alert'); | ||
| toastElement.setAttribute('aria-live', 'assertive'); | ||
| toastElement.setAttribute('aria-atomic', 'true'); | ||
| const toastElement = document.createElement("div"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you have a linter we could all install? It would be nice to have one tbh...
SilasMarvinOct 5, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I use prettier for javascript. I can setup a prettier configuration for our repos that will avoid things like this, but I'll also look into setting up eslint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please yeah, any one of them works, as long as it's easy to use.
| @@ -45,3 +45,5 @@ pgvector = { version = "0.2.2", features = [ "sqlx", "postgres" ] } | |||
| console-subscriber = "*" | |||
| glob = "*" | |||
| pgml-components = { path = "../packages/pgml-components" } | |||
| reqwest = { version = "0.11.20", features = ["json"] } | |||
| pgml = { version = "0.9.2", path = "../pgml-sdks/pgml/" } | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Love monorepos! Things are just easier.
No description provided.