- Notifications
You must be signed in to change notification settings - Fork328
gitbook assets#1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gitbook assets#1052
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| render(cluster, &path, guides, "Guides", &Path::new("docs")).await | ||
| use rocket::fs::NamedFile; | ||
| #[get("/docs/guides/.gitbook/assets/<path>", rank = 10)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can't use the fileserver because we need the path to not be exact, but rather the relative gitbook path.
| @@ -48,7 +48,7 @@ | |||
| </li> | |||
| <li class="nav-item d-flex align-items-center"> | |||
| <a class="nav-link p-lg-0" href="/docs/guides/setup/quick_start_with_docker">Docs</a> | |||
| <a class="nav-link p-lg-0" href="/docs/guides/README">Docs</a> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not very SEO friendly imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, but we can't control this lever in gitbook... and then again... it is kinda devvy.
| .header_counter | ||
| .fetch_add(1, std::sync::atomic::Ordering::SeqCst); | ||
| let id = format!("header-{}", id); | ||
| let id = meta.content.to_case(convert_case::Case::Kebab); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not unique enough, we have duplicate headers in blogs and docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should dedup them. URLS are part of the UX, and we're also losing control of this to gitbook.
levkk commentedOct 5, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Do you think we should place these into We should at least go through these to validate that all the basics are there and we haven't removed important information. |
TODO