Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Dont crash the dashboard if search index is not built#1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
levkk merged 2 commits intomasterfromlevkk-empty-search-index
Sep 17, 2023

Conversation

levkk
Copy link
Contributor

@levkklevkk commentedSep 16, 2023•
edited
Loading

  1. This is kinda annoying since while really important, searching is not the only functionality the app provides, so if we don't have the search index built for any reason, we should not just crash.
  2. Useful for testing. The search index is not necessary for tests and it's a bit time consuming to build for each integration test.

@levkklevkk changed the titleDont crash the app if search index is not builtDont crash the dashboard if search index is not builtSep 16, 2023
@levkklevkk marked this pull request as ready for reviewSeptember 17, 2023 16:24
@levkklevkk merged commitc41340b intomasterSep 17, 2023
@levkklevkk deleted the levkk-empty-search-index branchSeptember 17, 2023 16:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@levkk
[8]ページ先頭
©2009-2025 Movatter.jp