Commitfbc0540

committed

rollbacks

1 parent78c5628 commitfbc0540Copy full SHA for fbc0540

File tree

+15

-5

lines changed

+15

-5

lines changed

Lines changed: 13 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -440,13 +440,23 @@ def train(`
`440`	`440`	`)`
`441`	`441`
`442`	`442`	`snapshot=Snapshot.create(relation_name,y_column_name,test_size,test_sampling)`
`443`		`-best_model=None`
`444`		`-best_error=None`
	`443`	`+deployed=Model.find_deployed(project.id)`
	`444`	`+`
	`445`	`+# Let's assume that the deployed model is better for now.`
	`446`	`+best_model=deployed`
	`447`	`+best_error=best_model.mean_squared_errorifbest_modelelseNone`
`445`	`448`
`446`	`449`	`foralgorithm_nameinalgorithms:`
`447`	`450`	`model=Model.create(project,snapshot,algorithm_name)`
`448`	`451`	`model.fit(snapshot)`
	`452`	`+`
	`453`	`+# Find the better model and deploy that.`
`449`	`454`	`ifbest_errorisNoneormodel.mean_squared_error<best_error:`
`450`	`455`	`best_error=model.mean_squared_error`
`451`	`456`	`best_model=model`
`452`		`-best_model.deploy()`
	`457`	`+`
	`458`	`+ifdeployedanddeployed.id==best_model.id:`
	`459`	`+return"rolled back"`
	`460`	`+else:`
	`461`	`+best_model.deploy()`
	`462`	`+return"deployed"`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -109,9 +109,9 @@ RETURNS TABLE(project_name TEXT, objective TEXT, status TEXT)`
`109`	`109`	`AS $$`
`110`	`110`	`frompgml.model import train`
`111`	`111`
`112`		`-train(project_name, objective, relation_name, y_column_name)`
	`112`	`+status=train(project_name, objective, relation_name, y_column_name)`
`113`	`113`
`114`		`-return [(project_name, objective,"deployed")]`
	`114`	`+return [(project_name, objective,status)]`
`115`	`115`	`$$ LANGUAGE plpython3u;`
`116`	`116`
`117`	`117`	`---`

Comments

(0)