- Notifications
You must be signed in to change notification settings - Fork4.9k
FDW extension patch#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
3f5b45b Patch status at 20151001
pramseyed33e74 Fixes from Andres Freund patch review
pramsey5e495de Comment use of hash vis-a-vis cache invalidation
pramseya04c63b Merge branch 'master' into fdw-extension-support
pramsey37970c2 Remove comment change
pramseyd77489f Ensure shippability info is cached per-server
pramseybda377f Add regression test and small fix turned up by regression
pramsey91b6622 Use pgsql MemSet?
pramseyFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
Patch status at 20151001
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit3f5b45b606a781a603578ac73dc79e67da38b275
There are no files selected for viewing
6 changes: 4 additions & 2 deletionscontrib/postgres_fdw/Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
30 changes: 24 additions & 6 deletionscontrib/postgres_fdw/deparse.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
139 changes: 139 additions & 0 deletionscontrib/postgres_fdw/expected/shippable.out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| -- =================================================================== | ||
| -- create FDW objects | ||
| -- =================================================================== | ||
| -- Error, extension isn't installed yet | ||
| ALTER SERVER loopback OPTIONS (ADD extensions 'cube'); | ||
| ERROR: required extension "cube" is not installed | ||
| HINT: Extension must be installed locally before it can be used on a remote server. | ||
| -- Try again | ||
| CREATE EXTENSION cube; | ||
| ALTER SERVER loopback OPTIONS (ADD extensions 'cube'); | ||
| ALTER SERVER loopback OPTIONS (DROP extensions); | ||
| -- =================================================================== | ||
| -- create objects used through FDW loopback server | ||
| -- =================================================================== | ||
| CREATE SCHEMA "SH 1"; | ||
| CREATE TABLE "SH 1"."TBL 1" ( | ||
| "C 1" int NOT NULL, | ||
| c2 int NOT NULL, | ||
| c3 cube, | ||
| c4 timestamptz | ||
| ); | ||
| INSERT INTO "SH 1"."TBL 1" | ||
| SELECT id, | ||
| 2 * id, | ||
| cube(id,2*id), | ||
| '1970-01-01'::timestamptz + ((id % 100) || ' days')::interval | ||
| FROM generate_series(1, 1000) id; | ||
| ANALYZE "SH 1"."TBL 1"; | ||
| -- =================================================================== | ||
| -- create foreign table | ||
| -- =================================================================== | ||
| CREATE FOREIGN TABLE shft1 ( | ||
| "C 1" int NOT NULL, | ||
| c2 int NOT NULL, | ||
| c3 cube, | ||
| c4 timestamptz | ||
| ) SERVER loopback | ||
| OPTIONS (schema_name 'SH 1', table_name 'TBL 1'); | ||
| -- =================================================================== | ||
| -- simple queries | ||
| -- =================================================================== | ||
| -- without operator shipping | ||
| EXPLAIN (COSTS false) SELECT * FROM shft1 LIMIT 1; | ||
| QUERY PLAN | ||
| ----------------------------- | ||
| Limit | ||
| -> Foreign Scan on shft1 | ||
| (2 rows) | ||
| EXPLAIN VERBOSE SELECT c2 FROM shft1 WHERE c3 && cube(1.5,2.5); | ||
| QUERY PLAN | ||
| --------------------------------------------------------------------- | ||
| Foreign Scan on public.shft1 (cost=100.00..205.06 rows=15 width=4) | ||
| Output: c2 | ||
| Filter: (shft1.c3 && '(1.5),(2.5)'::cube) | ||
| Remote SQL: SELECT c2, c3 FROM "SH 1"."TBL 1" | ||
| (4 rows) | ||
| SELECT c2 FROM shft1 WHERE c3 && cube(1.5,2.5); | ||
| c2 | ||
| ---- | ||
| 2 | ||
| 4 | ||
| (2 rows) | ||
| EXPLAIN VERBOSE SELECT c2 FROM shft1 WHERE c3 && '(1.5),(2.5)'::cube; | ||
| QUERY PLAN | ||
| --------------------------------------------------------------------- | ||
| Foreign Scan on public.shft1 (cost=100.00..205.06 rows=15 width=4) | ||
| Output: c2 | ||
| Filter: (shft1.c3 && '(1.5),(2.5)'::cube) | ||
| Remote SQL: SELECT c2, c3 FROM "SH 1"."TBL 1" | ||
| (4 rows) | ||
| -- with operator shipping | ||
| ALTER SERVER loopback OPTIONS (ADD extensions 'cube'); | ||
| EXPLAIN VERBOSE SELECT c2 FROM shft1 WHERE c3 && cube(1.5,2.5); | ||
| QUERY PLAN | ||
| --------------------------------------------------------------------------------------------------------- | ||
| Foreign Scan on public.shft1 (cost=100.00..146.86 rows=15 width=4) | ||
| Output: c2 | ||
| Remote SQL: SELECT c2 FROM "SH 1"."TBL 1" WHERE ((c3 OPERATOR(public.&&) '(1.5),(2.5)'::public.cube)) | ||
| (3 rows) | ||
| SELECT c2 FROM shft1 WHERE c3 && cube(1.5,2.5); | ||
| c2 | ||
| ---- | ||
| 2 | ||
| 4 | ||
| (2 rows) | ||
| EXPLAIN VERBOSE SELECT c2 FROM shft1 WHERE c3 && '(1.5),(2.5)'::cube; | ||
| QUERY PLAN | ||
| --------------------------------------------------------------------------------------------------------- | ||
| Foreign Scan on public.shft1 (cost=100.00..146.86 rows=15 width=4) | ||
| Output: c2 | ||
| Remote SQL: SELECT c2 FROM "SH 1"."TBL 1" WHERE ((c3 OPERATOR(public.&&) '(1.5),(2.5)'::public.cube)) | ||
| (3 rows) | ||
| EXPLAIN VERBOSE SELECT cube_dim(c3) FROM shft1 WHERE c3 && '(1.5),(2.5)'::cube; | ||
| QUERY PLAN | ||
| --------------------------------------------------------------------------------------------------------- | ||
| Foreign Scan on public.shft1 (cost=100.00..128.43 rows=7 width=32) | ||
| Output: cube_dim(c3) | ||
| Remote SQL: SELECT c3 FROM "SH 1"."TBL 1" WHERE ((c3 OPERATOR(public.&&) '(1.5),(2.5)'::public.cube)) | ||
| (3 rows) | ||
| SELECT cube_dim(c3) FROM shft1 WHERE c3 && '(1.5),(2.5)'::cube; | ||
| cube_dim | ||
| ---------- | ||
| 1 | ||
| 1 | ||
| (2 rows) | ||
| EXPLAIN VERBOSE SELECT c2 FROM shft1 WHERE cube_dim(c3) = 1 LIMIT 2; | ||
| QUERY PLAN | ||
| ------------------------------------------------------------------------------------- | ||
| Limit (cost=100.00..107.22 rows=2 width=4) | ||
| Output: c2 | ||
| -> Foreign Scan on public.shft1 (cost=100.00..154.18 rows=15 width=4) | ||
| Output: c2 | ||
| Remote SQL: SELECT c2 FROM "SH 1"."TBL 1" WHERE ((public.cube_dim(c3) = 1)) | ||
| (5 rows) | ||
| SELECT c2 FROM shft1 WHERE cube_dim(c3) = 1 LIMIT 2; | ||
| c2 | ||
| ---- | ||
| 2 | ||
| 4 | ||
| (2 rows) | ||
| -- =================================================================== | ||
| -- clean up | ||
| -- =================================================================== | ||
| DROP FOREIGN TABLE shft1; | ||
| DROP TABLE "SH 1"."TBL 1"; | ||
| DROP SCHEMA "SH 1"; | ||
| DROP EXTENSION cube; | ||
| ALTER SERVER loopback OPTIONS (DROP extensions); |
55 changes: 55 additions & 0 deletionscontrib/postgres_fdw/option.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
37 changes: 4 additions & 33 deletionscontrib/postgres_fdw/postgres_fdw.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.