NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitfe3b5eb

committed

REASSIGN OWNED: consider grants on tablespaces, too

Apparently this was considered in the original code (see commitcec3b0a) but I failed to notice that such entries would always beskipped by the database check at the start of the loop.Per bugs #7578 by Nikolay, #6116 by tushar.qa@gmail.com.

1 parente1be1df commitfe3b5ebCopy full SHA for fe3b5eb

File tree

1 file changed

-2

lines changed

src/backend/catalog
- pg_shdepend.c

1 file changed

-2

lines changed

`‎src/backend/catalog/pg_shdepend.c`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1217,8 +1217,12 @@ shdepDropOwned(List *roleids, DropBehavior behavior)`
`1217`	`1217`	`Form_pg_shdependsdepForm= (Form_pg_shdepend)GETSTRUCT(tuple);`
`1218`	`1218`	`ObjectAddressobj;`
`1219`	`1219`
`1220`		`-/* We only operate on objects in the current database */`
`1221`		`-if (sdepForm->dbid!=MyDatabaseId)`
	`1220`	`+/*`
	`1221`	`+ * We only operate on shared objects and objects in the current`
	`1222`	`+ * database`
	`1223`	`+ */`
	`1224`	`+if (sdepForm->dbid!=MyDatabaseId&&`
	`1225`	`+sdepForm->dbid!=InvalidOid)`
`1222`	`1226`	`continue;`
`1223`	`1227`
`1224`	`1228`	`switch (sdepForm->deptype)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfe3b5eb

File tree

1 file changed

1 file changed

`‎src/backend/catalog/pg_shdepend.c`

0 commit comments