NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commitf655a9f

committed

Fix typo in pg_srand48 (srand48 in older branches).

">" should be ">>". This typo results in failure to use all of the bitsof the provided seed.This might rise to the level of a security bug if we were relying onsrand48 for any security-critical purposes, but we are not --- in fact,it's not used at all unless the platform lacks srandom(), which isimprobable. Even on such a platform the exposure seems minimal.Reported privately by Andres Freund.

1 parentcbd5154 commitf655a9fCopy full SHA for f655a9f

File tree

1 file changed

-1

lines changed

src/port
- rand.c

1 file changed

-1

lines changed

`‎src/port/rand.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ srand48(long seed)`
`71`	`71`	`{`
`72`	`72`	`_rand48_seed[0]=RAND48_SEED_0;`
`73`	`73`	`_rand48_seed[1]= (unsigned short)seed;`
`74`		`-_rand48_seed[2]= (unsigned short) (seed>16);`
	`74`	`+_rand48_seed[2]= (unsigned short) (seed >>16);`
`75`	`75`	`_rand48_mult[0]=RAND48_MULT_0;`
`76`	`76`	`_rand48_mult[1]=RAND48_MULT_1;`
`77`	`77`	`_rand48_mult[2]=RAND48_MULT_2;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf655a9f

File tree

1 file changed

1 file changed

`‎src/port/rand.c`

0 commit comments