- Notifications
You must be signed in to change notification settings - Fork4.9k
Commited29089
committed
Propagate CTE property flags when copying a CTE list into a rule.
rewriteRuleAction() neglected this step, although it was careful topropagate other similar flags such as hasSubLinks or hasRowSecurity.Omitting to transfer hasRecursive is just cosmetic at the moment,but omitting hasModifyingCTE is a live bug, since the executorcertainly looks at that.The proposed test case only fails back to v10, but since the executorexamines hasModifyingCTE in 9.x as well, I suspect that a test casecould be devised that fails in older branches. Given the nearnessof the release deadline, though, I'm not going to spend time lookingfor a better test.Report and patch by Greg Nancarrow, cosmetic changes by meDiscussion:https://postgr.es/m/CAJcOf-fAdj=nDKMsRhQzndm-O13NY4dL6xGcEvdX5Xvbbi0V7g@mail.gmail.com1 parentdd705a0 commited29089
File tree
3 files changed
+49
-0
lines changed- src
- backend/rewrite
- test/regress
- expected
- sql
3 files changed
+49
-0
lines changedLines changed: 6 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
536 | 536 |
| |
537 | 537 |
| |
538 | 538 |
| |
| 539 | + | |
| 540 | + | |
| 541 | + | |
539 | 542 |
| |
540 | 543 |
| |
541 | 544 |
| |
| |||
557 | 560 |
| |
558 | 561 |
| |
559 | 562 |
| |
| 563 | + | |
| 564 | + | |
| 565 | + | |
560 | 566 |
| |
561 | 567 |
| |
562 | 568 |
| |
|
Lines changed: 27 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2277 | 2277 |
| |
2278 | 2278 |
| |
2279 | 2279 |
| |
| 2280 | + | |
| 2281 | + | |
| 2282 | + | |
| 2283 | + | |
| 2284 | + | |
| 2285 | + | |
| 2286 | + | |
| 2287 | + | |
| 2288 | + | |
| 2289 | + | |
| 2290 | + | |
| 2291 | + | |
| 2292 | + | |
| 2293 | + | |
| 2294 | + | |
| 2295 | + | |
| 2296 | + | |
| 2297 | + | |
| 2298 | + | |
| 2299 | + | |
| 2300 | + | |
| 2301 | + | |
| 2302 | + | |
| 2303 | + | |
| 2304 | + | |
| 2305 | + | |
| 2306 | + | |
2280 | 2307 |
| |
2281 | 2308 |
| |
2282 | 2309 |
| |
|
Lines changed: 16 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1070 | 1070 |
| |
1071 | 1071 |
| |
1072 | 1072 |
| |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
1073 | 1089 |
| |
1074 | 1090 |
| |
1075 | 1091 |
| |
|
0 commit comments
Comments
(0)