NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commite89f4c6

committed

Fix test case to do what it intends to

This test case intended to fail because setting a column as generated tothe partitioned table while leaving the partition alone is not allowed;but instead failed because of a discrepancy of not-null constraint. Fixthis by adding the not-null constraint first, then set the column asgenerated in a separate ALTER TABLE command, which gets the expectederror. Also, because the next test also wants to set the column asnot-null, add a BEGIN/ROLLBACK block so that the added not-null isremoved.Oversight in6995863.

1 parent3ca43db commite89f4c6Copy full SHA for e89f4c6

File tree

2 files changed

-3

lines changed

src/test/regress
- expected
  - identity.out
- sql
  - identity.sql

2 files changed

-3

lines changed

`‎src/test/regress/expected/identity.out`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -756,11 +756,13 @@ ALTER TABLE pitest3_p1`
`756`	`756`	`ALTER COLUMN f3 ADD GENERATED ALWAYS AS IDENTITY (START WITH 3);`
`757`	`757`	`ERROR: cannot add identity to a column of a partition`
`758`	`758`	`-- fails, changing only the partitioned table not allowed`
	`759`	`+BEGIN;`
	`760`	`+ALTER TABLE pitest3_p1 ALTER COLUMN f3 SET NOT NULL;`
`759`	`761`	`ALTER TABLE ONLY pitest3`
`760`		`- ALTER COLUMN f3 SET NOT NULL,`
`761`	`762`	`ALTER COLUMN f3 ADD GENERATED ALWAYS AS IDENTITY (START WITH 3);`
`762`		`-ERROR:constraint must be addedtochild tables too`
	`763`	`+ERROR:cannot add identitytoa column of only the partitioned table`
`763`	`764`	`HINT: Do not specify the ONLY keyword.`
	`765`	`+ROLLBACK;`
`764`	`766`	`ALTER TABLE pitest3`
`765`	`767`	`ALTER COLUMN f3 SET NOT NULL,`
`766`	`768`	`ALTER COLUMN f3 ADD GENERATED ALWAYS AS IDENTITY (START WITH 3);`

`‎src/test/regress/sql/identity.sql`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -418,9 +418,11 @@ ALTER TABLE pitest3_p1`
`418`	`418`	`ALTER COLUMN f3SETNOT NULL,`
`419`	`419`	`ALTER COLUMN f3 ADD GENERATED ALWAYSAS IDENTITY (START WITH3);`
`420`	`420`	`-- fails, changing only the partitioned table not allowed`
	`421`	`+BEGIN;`
	`422`	`+ALTERTABLE pitest3_p1 ALTER COLUMN f3SETNOT NULL;`
`421`	`423`	`ALTERTABLE ONLY pitest3`
`422`		`- ALTER COLUMN f3SETNOT NULL,`
`423`	`424`	`ALTER COLUMN f3 ADD GENERATED ALWAYSAS IDENTITY (START WITH3);`
	`425`	`+ROLLBACK;`
`424`	`426`	`ALTERTABLE pitest3`
`425`	`427`	`ALTER COLUMN f3SETNOT NULL,`
`426`	`428`	`ALTER COLUMN f3 ADD GENERATED ALWAYSAS IDENTITY (START WITH3);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite89f4c6

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/identity.out`

`‎src/test/regress/sql/identity.sql`

0 commit comments