NotificationsYou must be signed in to change notification settings
Fork4.9k
Star17.7k

Commite842791

committed

Fix unstable regression test added by commits59b71c6 et al.

The query didn't really have a preferred index, leading to platform-specific choices of which one to use. Adjust it to make sure tenk1_hundredis always chosen.Per buildfarm.

1 parent84c4313 commite842791Copy full SHA for e842791

File tree

2 files changed

-9

lines changed

src/test/regress
- expected
  - aggregates.out
- sql
  - aggregates.sql

2 files changed

-9

lines changed

`‎src/test/regress/expected/aggregates.out`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -2013,7 +2013,7 @@ CREATE AGGREGATE balk(`
`2013`	`2013`	`STYPE = int8,`
`2014`	`2014`	`"PARALLEL" = SAFE,`
`2015`	`2015`	`INITCOND = '0');`
`2016`		`-SELECT balk(1) FROM tenk1;`
	`2016`	`+SELECT balk(hundred) FROM tenk1;`
`2017`	`2017`	`balk`
`2018`	`2018`	`------`
`2019`	`2019`
`@@ -2047,17 +2047,17 @@ CREATE AGGREGATE balk(`
`2047`	`2047`	`ALTER TABLE tenk1 set (parallel_workers = 4);`
`2048`	`2048`	`SET LOCAL parallel_setup_cost=0;`
`2049`	`2049`	`SET LOCAL max_parallel_workers_per_gather=4;`
`2050`		`-EXPLAIN (COSTS OFF) SELECT balk(1) FROM tenk1;`
`2051`		`-QUERY PLAN`
`2052`		`---------------------------------------------------------------------------------`
	`2050`	`+EXPLAIN (COSTS OFF) SELECT balk(hundred) FROM tenk1;`
	`2051`	`+ QUERY PLAN`
	`2052`	`+-------------------------------------------------------------------------`
`2053`	`2053`	`Finalize Aggregate`
`2054`	`2054`	`-> Gather`
`2055`	`2055`	`Workers Planned: 4`
`2056`	`2056`	`-> Partial Aggregate`
`2057`		`- -> Parallel Index Only Scan usingtenk1_thous_tenthous on tenk1`
	`2057`	`+ -> Parallel Index Only Scan usingtenk1_hundred on tenk1`
`2058`	`2058`	`(5 rows)`
`2059`	`2059`
`2060`		`-SELECT balk(1) FROM tenk1;`
	`2060`	`+SELECT balk(hundred) FROM tenk1;`
`2061`	`2061`	`balk`
`2062`	`2062`	`------`
`2063`	`2063`

`‎src/test/regress/sql/aggregates.sql`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -868,7 +868,7 @@ CREATE AGGREGATE balk(`
`868`	`868`	`"PARALLEL"= SAFE,`
`869`	`869`	`INITCOND='0');`
`870`	`870`
`871`		`-SELECT balk(1)FROM tenk1;`
	`871`	`+SELECT balk(hundred)FROM tenk1;`
`872`	`872`
`873`	`873`	`ROLLBACK;`
`874`	`874`
`@@ -902,7 +902,7 @@ ALTER TABLE tenk1 set (parallel_workers = 4);`
`902`	`902`	`SET LOCAL parallel_setup_cost=0;`
`903`	`903`	`SET LOCAL max_parallel_workers_per_gather=4;`
`904`	`904`
`905`		`-EXPLAIN (COSTS OFF)SELECT balk(1)FROM tenk1;`
`906`		`-SELECT balk(1)FROM tenk1;`
	`905`	`+EXPLAIN (COSTS OFF)SELECT balk(hundred)FROM tenk1;`
	`906`	`+SELECT balk(hundred)FROM tenk1;`
`907`	`907`
`908`	`908`	`ROLLBACK;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite842791

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/aggregates.out`

`‎src/test/regress/sql/aggregates.sql`

0 commit comments